Show the invalid consensus branch id in the error message for read_v5_header_fragment
#1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
show-invalid-consensus-branch-id
branch
from
cff425f to
d99a048
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
==========================================
- Coverage 54.17% 54.15% -0.02%
==========================================
Files 176 176
Lines 20469 20476 +7
==========================================
Hits 11089 11089
- Misses 9380 9387 +7 ☔ View full report in Codecov by Sentry. |
daira
force-pushed
the
show-invalid-consensus-branch-id
branch
from
d99a048 to
22b432d
Compare
`read_v5_header_fragment`. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
show-invalid-consensus-branch-id
branch
from
22b432d to
495baa9
Compare
nuttycom
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.