[Misc] Code style: get rid of 'any' types

api/src/api/PageData.ts

@@ -49,9 +49,7 @@ export interface PageData {
    */
   canEdit: boolean;
 
-  // TODO: remove any
-  toObject(): any; // eslint-disable-line
+  toObject(): Record<string, unknown>;
 
-  // TODO: remove any
-  fromObject(object: any): void; // eslint-disable-line
+  fromObject(object: Record<string, unknown>): void;
 }

api/src/api/WikiConfig.ts

@@ -20,7 +20,18 @@
 
 import type { Storage } from "./storage";
 
-export interface WikiConfig {
+type ConfigObject = {
+  name: string;
+  baseURL: string;
+  baseRestURL: string;
+  realtimeURL: string;
+  homePage: string;
+  serverRendering: boolean;
+  offline: boolean;
+  designSystem: string;
+};
+
+interface WikiConfig {
   name: string;
   // The base url of the backend endpoint
   baseURL: string;
@@ -48,9 +59,7 @@ export interface WikiConfig {
     offline: boolean,
   ): void;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  setConfigFromObject(configObject: any): void;
+  setConfigFromObject(configObject: ConfigObject): void;
 
   isSupported(format: string): boolean;
 
@@ -78,3 +87,5 @@ export interface WikiConfig {
    */
   getNewPageDefaultName(): string;
 }
+
+export type { ConfigObject, WikiConfig };

api/src/api/document.ts

@@ -31,18 +31,12 @@ export interface Document {
 
   setText(text: string): void;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  get(fieldName: string): any;
+  get(fieldName: string): unknown;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  set(fieldName: string, value: any): void;
+  set(fieldName: string, value: unknown): void;
 
   /*
    * Allows retrieving the source of the document
    */
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  getSource(): any;
+  getSource(): unknown;
 }

api/src/api/logger.ts

@@ -23,19 +23,11 @@ export interface Logger {
 
   setModule(module: string): void;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  debug(...data: any[]): void;
+  debug(...data: unknown[]): void;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  info(...data: any[]): void;
+  info(...data: unknown[]): void;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  warn(...data: any[]): void;
+  warn(...data: unknown[]): void;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  error(...data: any[]): void;
+  error(...data: unknown[]): void;
 }

api/src/components/DefaultPageData.ts

@@ -57,9 +57,7 @@ export class DefaultPageData implements PageData {
     this.version = "";
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  toObject(): any {
+  toObject(): Record<string, unknown> {
     return {
       id: this.id,
       name: this.name,
@@ -73,17 +71,26 @@ export class DefaultPageData implements PageData {
     };
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  fromObject(object: any): void {
-    this.id = object.id;
-    this.name = object.name;
-    this.source = object.source;
-    this.syntax = object.syntax;
-    this.html = object.html;
+  fromObject(object: Record<string, unknown>): void {
     this.document = new JSONLDDocument(object.document);
-    this.css = object.css;
-    this.js = object.js;
-    this.version = object.version;
+
+    // TODO: validate object shape with a library
+
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.id = object.id as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.name = object.name as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.source = object.source as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.syntax = object.syntax as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.html = object.html as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.css = object.css as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.js = object.js as any;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    this.version = object.version as any;
   }
 }

api/src/components/JSONLDDocument.ts

@@ -20,14 +20,16 @@
 
 import type { Document } from "../api/document";
 
+export type JsonLd = Record<string, unknown> & {
+  identifier: string;
+  name: string;
+  text: string;
+};
+
 export class JSONLDDocument implements Document {
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  protected jsonld: any;
+  protected jsonld: JsonLd;
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  constructor(jsonld: any) {
+  constructor(jsonld: JsonLd) {
     this.jsonld = jsonld;
   }
 
@@ -55,21 +57,15 @@ export class JSONLDDocument implements Document {
     this.jsonld.text = text;
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  get(fieldName: string): any {
+  get(fieldName: string): unknown {
     return this.jsonld[fieldName];
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  set(fieldName: string, value: any): void {
+  set(fieldName: string, value: unknown): void {
     this.jsonld[fieldName] = value;
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  getSource(): any {
+  getSource(): unknown {
     return this.jsonld;
   }
 }

api/src/components/defaultLogger.ts

@@ -38,32 +38,24 @@ export class DefaultLogger implements Logger {
     this.module = module;
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  debug(...data: any[]): void {
+  debug(...data: unknown[]): void {
     if (!this.loggerConfig || this.loggerConfig.hasLevelId(this.module, 4)) {
       data.unshift(this.module + ":");
     }
     console.debug.apply(null, data);
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  info(...data: any[]): void {
+  info(...data: unknown[]): void {
     data.unshift(this.module + ":");
     console.info.apply(null, data);
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  warn(...data: any[]): void {
+  warn(...data: unknown[]): void {
     data.unshift(this.module + ":");
     console.warn.apply(null, data);
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  error(...data: any[]): void {
+  error(...data: unknown[]): void {
     data.unshift(this.module + ":");
     console.error.apply(null, data);
   }

api/src/components/defaultWikiConfig.ts

@@ -19,7 +19,7 @@
  */
 
 import { inject, injectable } from "inversify";
-import type { WikiConfig } from "../api/WikiConfig";
+import type { ConfigObject, WikiConfig } from "../api/WikiConfig";
 import type { CristalApp } from "../api/cristalApp";
 import type { Logger } from "../api/logger";
 import type { Storage } from "../api/storage";
@@ -89,9 +89,7 @@ export class DefaultWikiConfig implements WikiConfig {
     this.offline = offline;
   }
 
-  // TODO get rid of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  setConfigFromObject(configObject: any): void {
+  setConfigFromObject(configObject: ConfigObject): void {
     this.name = configObject.name;
     this.baseURL = configObject.baseURL;
     this.baseRestURL = configObject.baseRestURL;

core/backends/backend-xwiki/src/xwikiStorage.ts

@@ -272,7 +272,7 @@ export class XWikiStorage extends AbstractStorage {
     try {
       // TODO get rid of any
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      const fieldMapping: any = document.get("xwikiMapping")[fieldName];
+      const fieldMapping = (document.get("xwikiMapping") as any)[fieldName];
       let type = fieldMapping["type"];
       let xwikiFieldName = fieldMapping["fieldName"];
       if (type == null) {

core/markdown/markdown-default/src/parseInternalImages.ts

@@ -174,8 +174,7 @@ export function parseInternalImages(
   remoteURLSerializer: RemoteURLSerializer,
 ): MarkdownIt.Core.RuleCore {
   return function (state: StateCore): void {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    state.tokens.forEach((blockToken: any) => {
+    state.tokens.forEach((blockToken) => {
       if (blockToken.type == "inline") {
         handleInlineBlockToken(
           blockToken,

core/markdown/markdown-default/src/parseInternalLinks.ts

@@ -197,8 +197,7 @@ export function parseInternalLinks(
   remoteURLSerializer: RemoteURLSerializer,
 ): MarkdownIt.Core.RuleCore {
   return function (state: StateCore): void {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    state.tokens.forEach((blockToken: any) => {
+    state.tokens.forEach((blockToken) => {
       if (blockToken.type == "inline") {
         handleInlineBlockToken(
           blockToken,

ds/vuetify/src/vue/__tests__/utils/vuetify.ts

@@ -32,8 +32,7 @@ const vuetify = createVuetify({
  * Provide the required options for testing vuetify, and merge them with existing
  * @param options - the existing options to merge
  */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function addVuetifyOptions(options: any) {
+export function addVuetifyOptions(options: Record<string, unknown>) {
   return {
     ...options,
     global: {

rendering/rendering/src/components/wikimodel-teavm.ts

@@ -28,9 +28,7 @@ export class WikiModel {
   public async isWikiModelLoaded(): Promise<boolean> {
     console.debug("In isWikiModelLoaded");
 
-    // TODO get rid of any
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const sleep = (ms: any) => new Promise((r) => setTimeout(r, ms));
+    const sleep = (ms: number) => new Promise((r) => setTimeout(r, ms));
 
     for (let i = 0; i < 10; i++) {
       // @ts-expect-error TODO describe

rendering/rendering/src/components/wikimodel.ts

@@ -44,9 +44,7 @@ export class WikiModel2 {
   }
 
   public async isWikiModelLoaded(): Promise<boolean> {
-    // TODO get rid of any
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const sleep = (ms: any) => new Promise((r) => setTimeout(r, ms));
+    const sleep = (ms: number) => new Promise((r) => setTimeout(r, ms));
 
     for (let i = 0; i < 10; i++) {
       // @ts-expect-error TODO describe

sharedworker/impl/src/components/defaultQueueWorker.ts

@@ -28,9 +28,7 @@ import type { MyWorker, QueueWorker } from "@xwiki/cristal-sharedworker-api";
 
 @injectable()
 export default class DefaultQueueWorker implements QueueWorker {
-  // TODO remove use of any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  private workerInstance: any;
+  private workerInstance: Comlink.Remote<MyWorker> | null = null;
   private cristalApp: CristalApp;
   private logger: Logger;
 

skin/src/vue/contentTools.ts

@@ -107,20 +107,18 @@ export class ContentTools {
     const contentToInject = range.createContextualFragment(html);
     contentToInject
       .querySelectorAll("link[href], script[src]")
-      // TODO get rid of any
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      .forEach(function (resource: any) {
-        url1 = resource.src || resource.href;
-        document.querySelectorAll("link[href], script[src]").forEach(function (
-          // TODO get rid of any
-          // eslint-disable-next-line @typescript-eslint/no-explicit-any
-          resource2: any,
-        ) {
-          const url2 = resource2.src || resource2.href;
-          if (url1 && url1 == url2) {
-            return null;
-          }
-        });
+      .forEach(function (resource) {
+        url1 = resource.getAttribute("src") ?? resource.getAttribute("ref");
+        document
+          .querySelectorAll("link[href], script[src]")
+          .forEach(function (resource2) {
+            const url2 =
+              resource2.getAttribute("src") ?? resource2.getAttribute("href");
+
+            if (url1 && url1 == url2) {
+              return null;
+            }
+          });
       });
     return url1;
   }
@@ -222,9 +220,7 @@ export class ContentTools {
 
   public static mount(
     component: Component,
-    // TODO get rid of any
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    props: any,
+    props: Record<string, unknown>,
     children: unknown,
     element: HTMLElement,
     app: App,