[Misc] Code style: get rid of 'any' types #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
reviewed
Feb 26, 2025
| @@ -20,7 +20,18 @@ | |||
|
|
|||
| import type { Storage } from "./storage"; | |||
|
|
|||
| export interface WikiConfig { | |||
| type ConfigObject = { | |||
There was a problem hiding this comment.
If you export something please define which version it was introduced in with the @since annotation.
An explanation of the type in the tsdoc is also preferable.
manuelleduc
reviewed
Feb 26, 2025
Comment on lines
+79
to
+94
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.id = object.id as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.name = object.name as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.source = object.source as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.syntax = object.syntax as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.html = object.html as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.css = object.css as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.js = object.js as any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| this.version = object.version as any; |
There was a problem hiding this comment.
I'm not sure how this is better than simply definition the type of the object parameter as any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
N/A
Changes
Description
anytypeClarifications
N/A
Screenshots & Video
N/A
Executed Tests
N/A
Expected merging strategy