Properly handle line breaks in column value

[mrsdizzie]

Before this code tried to replace newlines with empty spaces, but it didn't always work because the new value would only use the replaced string if additional wrapping needed to be done due to size constraints. This updates the code to properly handle new lines in all content by creating an extra row for each one, using the same logic that already existed for wrapping longer content.

See wp-cli/entity-command#262 for an example of the currently broken behavior that this PR fixes

Example of new fixed output:

isla@Islas-MacBook-Pro ~/test $ wp post meta list 1
+---------+----------+--------------------+
| post_id | meta_key | meta_value         |
+---------+----------+--------------------+
| 1       | fruits   | apple              |
|         |          | banana             |
|         |          | mango              |
| 1       | foo      | bar                |
+---------+----------+--------------------+

isla@Islas-MacBook-Pro ~/test $ wp post get 1
+-----------------------+-------------------------------------------------------------------------------------------------------------------------------------------+
| Field                 | Value                                                                                                                                     |
+-----------------------+-------------------------------------------------------------------------------------------------------------------------------------------+
| ID                    | 1                                                                                                                                         |
| post_author           | 1                                                                                                                                         |
| post_date             | 2024-12-05 18:11:32                                                                                                                       |
| post_date_gmt         | 2024-12-05 18:11:32                                                                                                                       |
| post_content          | <!-- wp:paragraph -->                                                                                                                     |
|                       | <p>Welcome to WordPress. This is your first post. Edit or delete it, then start writing!</p>                                              |
|                       | <!-- /wp:paragraph -->                                                                                                                    |
| post_title            | Hello world!                                                                                                                              |
| post_excerpt          |                                                                                                                                           |
| post_status           | publish                                                                                                                                   |
| comment_status        | open                                                                                                                                      |
| ping_status           | open                                                                                                                                      |
| post_password         |                                                                                                                                           |
| post_name             | hello-world                                                                                                                               |
| to_ping               |                                                                                                                                           |
| pinged                |                                                                                                                                           |
| post_modified         | 2024-12-05 18:11:32                                                                                                                       |
| post_modified_gmt     | 2024-12-05 18:11:32                                                                                                                       |
| post_content_filtered |                                                                                                                                           |
| post_parent           | 0                                                                                                                                         |
| guid                  | http://macbook.local/?p=1                                                                                                                 |
| menu_order            | 0                                                                                                                                         |
| post_type             | post                                                                                                                                      |
| post_mime_type        |                                                                                                                                           |
| comment_count         | 1                                                                                                                                         |
| url                   | http://macbook.local/?p=1                                                                                                                 |
+-----------------------+-------------------------------------------------------------------------------------------------------------------------------------------+


# Smaller term
isla@Islas-MacBook-Pro ~/test $ wp post get 1
+-----------------------+-----------------------------------------+
| Field                 | Value                                   |
+-----------------------+-----------------------------------------+
| ID                    | 1                                       |
| post_author           | 1                                       |
| post_date             | 2024-12-05 18:11:32                     |
| post_date_gmt         | 2024-12-05 18:11:32                     |
| post_content          | <!-- wp:paragraph -->                   |
|                       | <p>Welcome to WordPress. This is your f |
|                       | irst post. Edit or delete it, then star |
|                       | t writing!</p>                          |
|                       | <!-- /wp:paragraph -->                  |
| post_title            | Hello world!                            |
| post_excerpt          |                                         |
| post_status           | publish                                 |
| comment_status        | open                                    |
| ping_status           | open                                    |
| post_password         |                                         |
| post_name             | hello-world                             |
| to_ping               |                                         |
| pinged                |                                         |
| post_modified         | 2024-12-05 18:11:32                     |
| post_modified_gmt     | 2024-12-05 18:11:32                     |
| post_content_filtered |                                         |
| post_parent           | 0                                       |
| guid                  | http://macbook.local/?p=1               |
| menu_order            | 0                                       |
| post_type             | post                                    |
| post_mime_type        |                                         |
| comment_count         | 1                                       |
| url                   | http://macbook.local/?p=1               |
+-----------------------+-----------------------------------------+

[swissspidy]

Thanks @mrsdizzie!

This looks good!

While testing, I realized that tabs (\t) have always slightly messed up table formatting due to tab length. What do you think about replacing tabs in tables with e.g. 4 spaces? Could be as simple as $value = str_replace( "\t", ' ', $value );