Replace tabs in tables with 4 spaces

[swissspidy]

While testing #179, I realized that tabs (\t) have always slightly messed up table formatting due to tab length.

By replacing them with spaces, the length calculation is correct again.

[mrsdizzie]

I tested this but I don't think it works properly because of the existing logic. Right now it only directly modifies $row to use $value if this condition is met :

php-cli-tools/lib/cli/table/Ascii.php

Line 144 in 77616d6

if ( $col_width && ( $original_val_width > $col_width || strpos( $value, "\n" ) !== false ) ) {

But if it isn't, then it just uses the original $row data to calculate padding:

php-cli-tools/lib/cli/table/Ascii.php

Lines 168 to 172 in 77616d6

	$row = array_map(array($this, 'padColumn'), $row, array_keys($row));
	array_unshift($row, ''); // First border
	array_push($row, ''); // Last border
	$ret = join($this->_characters['border'], $row);

So it doesn't know about the tab replacement always.

I saw this in two ways when testing with the value apple\tbanana\tmango

When I first added it, output looked like this:

+---------+----------+--------------------+
| post_id | meta_key | meta_value         |
+---------+----------+--------------------+
| 1       | fruits   | apple              |
|         |          | banana             |
|         |          | mango              |
| 1       | foo      | bar                |
| 1       | fruitz   | apple    banana    |
|         |          |  mango             |
+---------+----------+--------------------+

Which seemed odd. Then when I added a longer string as another value, the table gets broken by the tab row again:

+---------+----------+------------------------------------------------------------------------+
| post_id | meta_key | meta_value                                                             |
+---------+----------+------------------------------------------------------------------------+
| 1       | fruits   | apple                                                                  |
|         |          | banana                                                                 |
|         |          | mango                                                                  |
| 1       | foo      | bar                                                                    |
| 1       | fruitz   | apple	banana	mango                                                     |
| 1       | fruitzz  | this is a really really really really really really really long string |
+---------+----------+------------------------------------------------------------------------+

Maybe a better place for this fix would be to modify $content here:

php-cli-tools/lib/cli/table/Ascii.php

Lines 200 to 202 in 77616d6

	private function padColumn($content, $column) {
	return $this->_characters['padding'] . Colors::pad( $content, $this->_widths[ $column ], $this->isPreColorized( $column ) ) . $this->_characters['padding'];
	}

To make sure it always removes tabs from the content no matter what

[swissspidy]

Yes that makes more sense, thanks!