-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul stats: decouple events from stats #1400
Merged
josecelano
merged 6 commits into
torrust:develop
from
josecelano:1395-overhaul-stats-decouple-events-from-stats
Mar 19, 2025
Merged
Overhaul stats: decouple events from stats #1400
josecelano
merged 6 commits into
torrust:develop
from
josecelano:1395-overhaul-stats-decouple-events-from-stats
Mar 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HTTP tracker core
Events are now generic even if they are only used for stats for now.
This was
linked to
issues
Mar 19, 2025
ACK 9eba80f |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1400 +/- ##
===========================================
- Coverage 82.01% 82.00% -0.02%
===========================================
Files 232 232
Lines 17051 17036 -15
Branches 17051 17036 -15
===========================================
- Hits 13985 13970 -15
Misses 2821 2821
Partials 245 245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new events are "generic" events that can be used for any purpose, not only generating stats. This will allow later to create one listener and metrics repository per server (socket address). See #1395.