Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul stats: decouple events from stats #1400

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Mar 19, 2025

The new events are "generic" events that can be used for any purpose, not only generating stats. This will allow later to create one listener and metrics repository per server (socket address). See #1395.

@josecelano
Copy link
Member Author

ACK 9eba80f

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 91.22807% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (34c4249) to head (9eba80f).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
packages/http-tracker-core/src/event/mod.rs 70.00% 6 Missing ⚠️
packages/udp-tracker-core/src/event/mod.rs 50.00% 6 Missing ⚠️
packages/udp-tracker-server/src/event/mod.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1400      +/-   ##
===========================================
- Coverage    82.01%   82.00%   -0.02%     
===========================================
  Files          232      232              
  Lines        17051    17036      -15     
  Branches     17051    17036      -15     
===========================================
- Hits         13985    13970      -15     
  Misses        2821     2821              
  Partials       245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josecelano josecelano merged commit cce6b61 into torrust:develop Mar 19, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
1 participant