You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To implement the segregated metrics for each server we need to create one event listeners and metrics repository for each service. That means the stats setup function will not work anymore. For example, the stats setup function for the HTTP core is
It creates the channel and subscriber one event listener. we need to separate the channel creation from the listeners subscriptions. My plan is to:
Move the event enums, sender trait and channel creation to a new "pure" events module.
Leave the listener subscription in the statistics module.
The new events are "generic" events that can be used for any purpose, not only generating stats.
This will allow later to create one listener and repo per server (socket address).
In this issue, I'm going to only split the modules internally, the statistics::setup::factory(...) function signature will be the same. We can removed it when we introduce the new listeners.
The text was updated successfully, but these errors were encountered:
9eba80f refactor: [#1395] rename send_stats_event to send_event (Jose Celano)
055db4e docs: [#1395] minor changes in comments (Jose Celano)
d8f1696 refactor: [#1398] extract event module in UDP server (Jose Celano)
ed93836 refactor: [#1397] extract event module in UDP core (Jose Celano)
7e364d1 refactor: [#1396] move event channel creation to events mod in HTTP tracker core (Jose Celano)
3d2243b refactor: [#1396] extract event module in HTTP core (Jose Celano)
Pull request description:
The new events are "generic" events that can be used for any purpose, not only generating stats. This will allow later to create one listener and metrics repository per server (socket address). See #1395.
ACKs for top commit:
josecelano:
ACK 9eba80f
Tree-SHA512: a88a6eeea28d08f3537704452056c086494a906da375de19fe4671ca7e74f6e00168543e4d4bdd9924da19b22b83aa307f6ff337a9fe6b33b1f3cd9c7e918bb6
To implement the segregated metrics for each server we need to create one event listeners and metrics repository for each service. That means the stats setup function will not work anymore. For example, the stats setup function for the HTTP core is
It creates the channel and subscriber one event listener. we need to separate the channel creation from the listeners subscriptions. My plan is to:
The new events are "generic" events that can be used for any purpose, not only generating stats.
This will allow later to create one listener and repo per server (socket address).
In this issue, I'm going to only split the modules internally, the
statistics::setup::factory(...)
function signature will be the same. We can removed it when we introduce the new listeners.The text was updated successfully, but these errors were encountered: