Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul core Tracker: extract torrents context (part 2) #1204

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jan 24, 2025

This is part 2 of the refactor initiated here.

The core Tracker after this refactor:

pub struct Tracker {
    /// The tracker configuration.
    config: Core,

    /// The service to check is a torrent is whitelisted.
    whitelist_authorization: Arc<whitelist::authorization::Authorization>,

    /// The in-memory torrents repository.
    in_memory_torrent_repository: Arc<InMemoryTorrentRepository>,

    /// The persistent torrents repository.
    db_torrent_repository: Arc<DatabasePersistentTorrentRepository>,
}

@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 24, 2025
@josecelano josecelano requested a review from da2ce7 January 24, 2025 08:46
@josecelano josecelano self-assigned this Jan 24, 2025
@josecelano josecelano linked an issue Jan 24, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (a4277a7) to head (046578d).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1204      +/-   ##
===========================================
+ Coverage    78.03%   78.39%   +0.36%     
===========================================
  Files          191      191              
  Lines        12999    13097      +98     
  Branches     12999    13097      +98     
===========================================
+ Hits         10144    10268     +124     
+ Misses        2687     2668      -19     
+ Partials       168      161       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1203-overhaul-core-tracker-extract-torrents-context-part-2 branch from 6ceb3fb to 046578d Compare January 24, 2025 10:50
@josecelano josecelano marked this pull request as ready for review January 24, 2025 10:50
@josecelano
Copy link
Member Author

ACK 046578d

@josecelano josecelano merged commit 731fd01 into torrust:develop Jan 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: extract torrents context (part 2)
1 participant