Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul core Tracker: extract torrents context (part 2) #1203

Closed
Tracked by #1181
josecelano opened this issue Jan 23, 2025 · 0 comments · Fixed by #1204
Closed
Tracked by #1181

Overhaul core Tracker: extract torrents context (part 2) #1203

josecelano opened this issue Jan 23, 2025 · 0 comments · Fixed by #1204
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat

Comments

@josecelano
Copy link
Member

Parent issue: #1181

This continues the work stared here.
@josecelano josecelano added - Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat labels Jan 23, 2025
@josecelano josecelano self-assigned this Jan 23, 2025
@josecelano josecelano mentioned this issue Jan 23, 2025
Closed
26 tasks
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 24, 2025
@josecelano
refactor: [torrust#1203] inline methods in core tracker
94673d6 
For the InMemoryTorrentRepository.
@josecelano josecelano linked a pull request Jan 24, 2025 that will close this issue
Overhaul core Tracker: extract torrents context (part 2) #1204
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 24, 2025
@josecelano
refactor: [torrust#1203] move test
2ac68f6
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 24, 2025
@josecelano
refactor: [torrust#1203] use InMemoryTorrentRepository directly in co…
0f1b2fb 
…re tracker tests
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 24, 2025
@josecelano
refactor: [torrust#1203] use directly the InMemoryTorrentRepository
6ceb3fb
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 24, 2025
@josecelano
refactor: [torrust#1203] use directly the InMemoryTorrentRepository
046578d
josecelano added a commit that referenced this issue Jan 24, 2025
@josecelano
Merge #1204: Overhaul core Tracker: extract torrents context (part 2)
731fd01 
046578d refactor: [#1203] use directly the InMemoryTorrentRepository (Jose Celano)
0f1b2fb refactor: [#1203] use InMemoryTorrentRepository directly in core tracker tests (Jose Celano)
2ac68f6 refactor: [#1203] move test (Jose Celano)
94673d6 refactor: [#1203] inline methods in core tracker (Jose Celano)

Pull request description:

  This is part 2 of the refactor initiated [here](#1202).

  The core `Tracker` after this refactor:

  ```rust
  pub struct Tracker {
      /// The tracker configuration.
      config: Core,

      /// The service to check is a torrent is whitelisted.
      whitelist_authorization: Arc<whitelist::authorization::Authorization>,

      /// The in-memory torrents repository.
      in_memory_torrent_repository: Arc<InMemoryTorrentRepository>,

      /// The persistent torrents repository.
      db_torrent_repository: Arc<DatabasePersistentTorrentRepository>,
  }
  ```

ACKs for top commit:
  josecelano:
    ACK 046578d

Tree-SHA512: db32af87815375ca570b81392c392dae0b602d12f54543c413d34f6a8dcb69f7e2f56a56e5d552a271d7fe2e4f751277d9f6e204caee297a2e3333f6a7b77e24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul core Tracker: extract torrents context (part 2) josecelano/torrust-tracker
1 participant
@josecelano