Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for internal repository #1536

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

takanotaiga
Copy link
Member

@takanotaiga takanotaiga commented Feb 25, 2025

Abstract

This change is to align with the internal project.

Background

N/A

Details

Change the getTrafficLight function from a protected function to a public function.

References

Destructive Changes

N/A

Known Limitations

N/A

@takanotaiga takanotaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Feb 25, 2025
@takanotaiga takanotaiga self-assigned this Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Copy link

Failure optional scenarios

Note

This is an experimental check and does not block merging the pull-request.
But, please be aware that this may indicate a regression.

scenario failed: execution_time_test
      <failure type="SimulationFailure" message="CustomCommandAction typed &quot;exitFailure&quot; was triggered by the named Conditions {&quot;update time checker&quot;, &quot;avoid startup&quot;}: {&quot;update time checker&quot;: Is the /simulation/interpreter/execution_time/update (= 0.005513999999999999804267680759) is greaterThan 0.005?}, {&quot;avoid startup&quot;: Is the simulation time (= 5.849999999999987210230756318197) is greaterThan 1.000000000000000000000000000000?}" />

@takanotaiga takanotaiga changed the title Fix for intternal repository Fix for internal repository Feb 25, 2025
@takanotaiga takanotaiga marked this pull request as ready for review February 25, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants