Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #370 annotation less perception evaluator #373

Merged
merged 44 commits into from
Mar 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
7890e0a
feat: add annotation_less_perception files
hayato-m126 Feb 28, 2024
da3efee
feat: update node
hayato-m126 Feb 29, 2024
be77183
fix: typo
hayato-m126 Feb 29, 2024
0adaca0
fix: bug
hayato-m126 Feb 29, 2024
b26214d
feat: update threshold
hayato-m126 Feb 29, 2024
27d432f
docs: update
hayato-m126 Feb 29, 2024
d662ba2
feat: update cli
hayato-m126 Feb 29, 2024
9775b4b
fix: lint
hayato-m126 Mar 1, 2024
081eafd
revert: LaunchSensing
hayato-m126 Mar 1, 2024
ae9c58d
docs: update use case annotation_less_perception
hayato-m126 Mar 1, 2024
c28f561
docs: update
hayato-m126 Mar 1, 2024
695703a
feat: update set frame
hayato-m126 Mar 1, 2024
2194b5c
docs: update document
hayato-m126 Mar 1, 2024
8b9ab45
feat: override threshold
hayato-m126 Mar 4, 2024
ccbc061
debug: pass argument
hayato-m126 Mar 4, 2024
ef4784d
fix: pre-commit
hayato-m126 Mar 4, 2024
5afc8c5
fix: pre-commit
hayato-m126 Mar 4, 2024
582141a
chore: add word to dict
hayato-m126 Mar 4, 2024
6191eb9
fix: typo
hayato-m126 Mar 4, 2024
0d1cd28
fix: set additional_parameter to evaluator node
hayato-m126 Mar 4, 2024
f864c39
feat: If the threshold value for judgment does not exist, set a provi…
hayato-m126 Mar 4, 2024
b9da37a
chore: update result.json
hayato-m126 Mar 4, 2024
65641b7
docs: update document
hayato-m126 Mar 4, 2024
bcefc99
chore: format
hayato-m126 Mar 4, 2024
da2c4e5
docs: update
hayato-m126 Mar 4, 2024
3efb6a0
chore: replace annotation_less with annotationless
hayato-m126 Mar 5, 2024
8e77722
fix: launch module
hayato-m126 Mar 5, 2024
a7972f3
fix: typo
hayato-m126 Mar 5, 2024
9673e8c
fix: typo
hayato-m126 Mar 5, 2024
c899221
docs: add quick start
hayato-m126 Mar 5, 2024
2b0503c
feat: add PassRange
hayato-m126 Mar 5, 2024
a9db904
feat: support update pass_range using launch argument
hayato-m126 Mar 5, 2024
6305532
feat: update pass_range
hayato-m126 Mar 5, 2024
b1260ca
docs: add English document
hayato-m126 Mar 6, 2024
197275d
docs: add index
hayato-m126 Mar 6, 2024
395c909
docs: fix file name
hayato-m126 Mar 6, 2024
96a20a9
fix: pre-commit
hayato-m126 Mar 6, 2024
bb009f6
fix: file name
hayato-m126 Mar 6, 2024
8bf8a14
fix: file name
hayato-m126 Mar 6, 2024
24b9ac3
chore: annotation less -> annotationless
hayato-m126 Mar 6, 2024
becaa29
chore: title
hayato-m126 Mar 6, 2024
be94a21
chore: add reuslt.jsonl for unit test
hayato-m126 Mar 7, 2024
68f93f7
chore: add unit test
hayato-m126 Mar 7, 2024
b1eb897
fix: pre-commit
hayato-m126 Mar 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: bug
hayato-m126 committed Feb 29, 2024
commit 0adaca08d6d10214357170a8757f9c113bb545d4
Original file line number Diff line number Diff line change
@@ -13,7 +13,6 @@
# limitations under the License.

from dataclasses import dataclass
from typing import ClassVar
from typing import Literal

from diagnostic_msgs.msg import DiagnosticArray
@@ -31,7 +30,7 @@ class Evaluation(BaseModel):
Conditions: dict | None


class AnnotationLessPercpetionSenario(Scenario):
class AnnotationLessPerceptionScenario(Scenario):
Evaluation: Evaluation


@@ -52,7 +51,7 @@ def set_frame(self, msg: DiagnosticArray) -> dict:
return rtn_dict


class AnnotationLessPercpetionResult(ResultBase):
class AnnotationLessPerceptionResult(ResultBase):
def __init__(self, condition) -> None: # noqa
# condition is for future extensibility and code commonality
super().__init__()
5 changes: 4 additions & 1 deletion driving_log_replayer/driving_log_replayer/evaluator.py
Original file line number Diff line number Diff line change
@@ -81,7 +81,10 @@ def __init__(self, name: str, scenario_class: Callable, result_class: Callable)
try:
self._scenario = load_scenario(Path(self._scenario_path), scenario_class)
evaluation_condition = {}
if hasattr(self._scenario.Evaluation, "Conditions"):
if (
hasattr(self._scenario.Evaluation, "Conditions")
and self._scenario.Evaluation.Conditions is not None
):
evaluation_condition = self._scenario.Evaluation.Conditions
self._result_writer = ResultWriter(
self._result_json_path,
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ def generate_launch_description() -> launch.LaunchDescription:
sensing=LaunchConfiguration("sensing"),
localization="false",
)
rviz_node = cmn.get_rviz("annotation_less_perception.rviz")
rviz_node = cmn.get_rviz("autoware.rviz")
evaluator_node = cmn.get_evaluator_node("annotation_less_perception")

player_normal = cmn.get_player(
Original file line number Diff line number Diff line change
@@ -17,15 +17,15 @@

from diagnostic_msgs.msg import DiagnosticArray

from driving_log_replayer.annotation_lees_perception import AnnotationLessResult
from driving_log_replayer.annotation_lees_perception import AnnotationLessScenario
from driving_log_replayer.annotation_lees_perception import AnnotationLessPerceptionResult
from driving_log_replayer.annotation_lees_perception import AnnotationLessPerceptionScenario
from driving_log_replayer.evaluator import DLREvaluator
from driving_log_replayer.evaluator import evaluator_main


class AnnotationLessPerceptionEvaluator(DLREvaluator):
def __init__(self, name: str) -> None:
super().__init__(name, AnnotationLessScenario, AnnotationLessResult)
super().__init__(name, AnnotationLessPerceptionScenario, AnnotationLessPerceptionResult)

self.__sub_diagnostics = self.create_subscription(
DiagnosticArray,
1 change: 0 additions & 1 deletion sample/annotation_less_perception/scenario.yaml
Original file line number Diff line number Diff line change
@@ -9,4 +9,3 @@ Evaluation:
UseCaseName: annotation_less_perception
UseCaseFormatVersion: 0.1.0
Conditions: null