Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #370 annotation less perception evaluator #373

Merged
merged 44 commits into from
Mar 7, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Feb 29, 2024

Types of PR

  • New Features

Description

  • add annotation_less_perception_evaluator

docs: https://github.com/tier4/driving_log_replayer/blob/feat/%23370-annotation-less-perception-evaluator/docs/use_case/annotation_less_perception.ja.md

How to review this PR

Others

closes: #370

@hayato-m126 hayato-m126 marked this pull request as ready for review March 4, 2024 09:13
@hayato-m126 hayato-m126 requested a review from kosuke55 March 4, 2024 09:37
Comment on lines 71 to 78
#### 以前のテスト結果ファイルから与える

こちらの方法をメインに使う想定。
Autoware Evaluatorで、テストを実行し、出力されたresult.jsonlのファイルパスを指定すると、指定したファイルに記述されている最後のMetrics値を判定基準値として利用する。

利用のイメージを以下に示す。

![threshold](./images/annotation_less_threshold.drawio.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いです!! 👍
Evaluator上で以前の結果使ってあるスコアが一定以上下がった場合はfailとしたいです!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あまりに値が変化した場合は計算がおかしいとか、そもそも認識した物体の母数が大きく変化しているとかそういうことがありえるから、弾きたいということでしょうか?

Copy link
Contributor

@kosuke55 kosuke55 Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

弾くというかsuccess/failの意味でのfailにしたいです。

Autoware Evaluatorで、テストを実行し、出力されたresult.jsonlのファイルパスを指定すると、指定したファイルに記述されている最後のMetrics値を判定基準値として利用する。

これで前日の結果の閾値に使ってsuceess/failの判定が出来るという意味かと思うので、ひとまずやりたいこと出来ていると思います!

もう少し理想的ですと、毎回の実行で多少のスコアのぶれはあると思うので、少しでも閾値が下がったfailではなくて、

あるスコアが一定以上下がった場合

predicted_path_deviation_5.00 が前日と比べて、0.5下がった場合はfailとか閾値の差分を指定できたらいいかなと思いました。(あるいはrateにして前日と比べてスコアが0.95以下とか?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kosuke55
こんな感じでどうでしょうか?launch argでの指定はこのあと対応します。
2b0503c

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最新のコミットでlaunch argumentでレンジを変更出来る機能に対応させました。
もらったコメントから考えられることは全部やった想定

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!!!!良いです!

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in file name:
annotaitonless -> annotationless

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting.

fixed a7972f3

@@ -15,3 +15,4 @@ nav:
- perception.ja.md
- performance_diag.en.md
- performance_diag.ja.md
- annotationless_perception.ja.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the English document today.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could You please provide these images in english?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added English image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could You please provide these images in english?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added English document.

@hayato-m126 hayato-m126 merged commit 104ca70 into develop Mar 7, 2024
4 checks passed
@hayato-m126 hayato-m126 deleted the feat/#370-annotation-less-perception-evaluator branch March 7, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create annotation_less_perception_evaluator
3 participants