Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(awsim_sensor_kit_launch): remove reference to tamagawa_imu_driver #32

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 20, 2025

Description

This PR removes the tamagawa_imu_driver package from the dependency list.

See autowarefoundation/autoware#5804 and autowarefoundation/autoware#3366 (comment)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…river

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@xmfcx
Copy link

xmfcx commented Feb 21, 2025

@mitsudome-r @mackierx111 @YoshinoriTsutake could you review this?

This removes an unused dependency from this package. Won't break the compatibility.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! LGTM

@youtalk youtalk merged commit 9a2bec4 into tier4:main Feb 21, 2025
8 of 9 checks passed
@esteve esteve deleted the remove-tamagawa-imu-driver branch February 24, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants