Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to tamagawa_imu_driver #5804

Open
4 tasks done
esteve opened this issue Feb 19, 2025 · 6 comments
Open
4 tasks done

Remove references to tamagawa_imu_driver #5804

esteve opened this issue Feb 19, 2025 · 6 comments

Comments

@esteve
Copy link
Contributor Author

esteve commented Feb 19, 2025

I can't fork awsim_sensor_kit_launch because it's already a fork of awsim_labs_sensor_kit_launch and GitHub doesn't let me. Once the changes in awsim_sensor_kit_launch are merged, I'll open a PR for the other repo.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 20, 2025

@esteve thanks for the PRs, all looked alright, merged them all.

Now only https://github.com/tier4/awsim_sensor_kit_launch is left 🏁

@esteve
Copy link
Contributor Author

esteve commented Feb 20, 2025

@xmfcx thanks for reviewing all the PRs so quickly 🙏 I've submitted tier4/awsim_sensor_kit_launch#32, once that is merged, I believe all the changes would be done.

@youtalk
Copy link
Member

youtalk commented Feb 21, 2025

@esteve Thank you for your contrinbution. The all sub issues were resolved. Let's close this issue.

@youtalk
Copy link
Member

youtalk commented Feb 21, 2025

In addition, we need to bump up sensor_kit_launch versions and remove this.
https://github.com/autowarefoundation/autoware/blob/main/autoware.repos#L88-L91

@esteve
Copy link
Contributor Author

esteve commented Feb 24, 2025

@youtalk references to tamagawa_imu_driver and pacmod_interface are removed from autoware.repos in #5801

I can bump up the versions, do you mean https://github.com/autowarefoundation/sample_sensor_kit_launch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants