feat(autoware_vehicle_cmd_gate): check the timestamp of input topics to avoid using old topics #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid using old topics (autowarefoundation#8084) * add prev_commands_ and check cmd's time stamp Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * add timestamp when is_engaged is false Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * add initialization for hazard_light timestamp in Commands Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * update README.md Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * fix typo Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix(autoware_vehicle_cmd_gate): rename the function that checks the continuity of topics Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * style(pre-commit): autofix * feat(autoware_vehicle_cmd_gate): check continuity using shared_ptr Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * feat(autoware_vehicle_cmd_gate): add INFO message for topics that are not receiving Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix template function to pass build-and-test-differential Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix(autoware_vehicle_cmd_gate): add #include <string> according to pre-commit.ci Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix(vehicle_cmd_gate) add underscores to member variable names for consistency Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
… occurs (autowarefoundation#8479) * add prev_commands_ and check cmd's time stamp Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * add timestamp when is_engaged is false Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * add initialization for hazard_light timestamp in Commands Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * update README.md Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * fix typo Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix(autoware_vehicle_cmd_gate): rename the function that checks the continuity of topics Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * style(pre-commit): autofix * feat(autoware_vehicle_cmd_gate): check continuity using shared_ptr Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * feat(autoware_vehicle_cmd_gate): add INFO message for topics that are not receiving Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix template function to pass build-and-test-differential Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix(autoware_vehicle_cmd_gate): add #include <string> according to pre-commit.ci Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * fix(vehicle_cmd_gate) add underscores to member variable names for consistency Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * style(pre-commit): autofix * feat(vehicle_cmd_gate): accept same topic unless mode change occurs Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> * feat(vehicle_cmd_gate): add default topic_name to getContinuousTopic function Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> --------- Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
shtokuda
changed the title
shmpwk
approved these changes
Aug 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cherry-pick:
autowarefoundation#8479
autowarefoundation#8084
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.