-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading deps and node to 20 #6
Conversation
Also gotta upgrade |
bump some more packages
works now. |
@thomaseizinger - this should be ready to review now :) Lemme know if you find something. Thnx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do the reformatting in a different PR please? It is hard to review all the changes with that mixed in!
I am surprised that there is even a formatting diff, I thought we had prettier set up in here. |
Sounds good can do 👍 |
Will open new one without reformatting. |
@thomaseizinger - created this PR: #7. Lemme know if that looks good :) or if there is anything to change. tq. |
Including #4