Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading deps and node to 20 #6

Closed
wants to merge 3 commits into from
Closed

Upgrading deps and node to 20 #6

wants to merge 3 commits into from

Conversation

NiharR27
Copy link
Contributor

Including #4

@NiharR27 NiharR27 changed the title Upgrading deps and node to 20 Upgrading deps and node to 20 [IN-PROGRESS] Jul 10, 2024
@NiharR27
Copy link
Contributor Author

Also gotta upgrade ts-jest

@NiharR27
Copy link
Contributor Author

works now.

@NiharR27 NiharR27 changed the title Upgrading deps and node to 20 [IN-PROGRESS] Upgrading deps and node to 20 Jul 10, 2024
@NiharR027 NiharR027 mentioned this pull request Jul 11, 2024
@NiharR027
Copy link

NiharR027 commented Jul 12, 2024

@thomaseizinger - this should be ready to review now :) Lemme know if you find something. Thnx!

Copy link
Owner

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do the reformatting in a different PR please? It is hard to review all the changes with that mixed in!

@thomaseizinger
Copy link
Owner

Could we do the reformatting in a different PR please? It is hard to review all the changes with that mixed in!

I am surprised that there is even a formatting diff, I thought we had prettier set up in here.

@NiharR027
Copy link

Could we do the reformatting in a different PR please? It is hard to review all the changes with that mixed in!

Sounds good can do 👍

@NiharR27
Copy link
Contributor Author

Will open new one without reformatting.

@NiharR27 NiharR27 closed this Aug 25, 2024
@NiharR27
Copy link
Contributor Author

@thomaseizinger - created this PR: #7. Lemme know if that looks good :) or if there is anything to change. tq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants