Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node20 #4

Closed
wants to merge 3 commits into from
Closed

Conversation

NiharR027
Copy link

@NiharR027 NiharR027 commented Jul 2, 2024

As per the comment on this PR: #3 (review)

Updating node12 to node20 to get rid of the warning on ci:

The following actions uses node12 which is deprecated and will be forced to run on node16: thomaseizinger/create-release@1.0.0. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

OR

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: thomaseizinger/create-release@1.0.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@NiharR027 NiharR027 mentioned this pull request Jul 2, 2024
@NiharR027 NiharR027 changed the title Update to node16 Update to node20 Jul 3, 2024
@thomaseizinger
Copy link
Owner

Can you re-generate the index.js with Node 20? We need to make sure it actually works with Node 20.

@NiharR027
Copy link
Author

Can you re-generate the index.js with Node 20? We need to make sure it actually works with Node 20.

True, can do after work 👌 Thanks for the reply.

@NiharR027
Copy link
Author

Can you re-generate the index.js with Node 20? We need to make sure it actually works with Node 20.

True, can do after work 👌 Thanks for the reply.

Hi @thomaseizinger - silly question, but how do I re-generate the index.js file?

@thomaseizinger
Copy link
Owner

Can you re-generate the index.js with Node 20? We need to make sure it actually works with Node 20.

True, can do after work 👌 Thanks for the reply.

Hi @thomaseizinger - silly question, but how do I re-generate the index.js file?

Check the package.json, yarn run build should do the trick.

@NiharR027
Copy link
Author

Can you re-generate the index.js with Node 20? We need to make sure it actually works with Node 20.

True, can do after work 👌 Thanks for the reply.

Hi @thomaseizinger - silly question, but how do I re-generate the index.js file?

Check the package.json, yarn run build should do the trick.

Thanks @thomaseizinger will do, just got flat out busy with other work. I will mention you again once I do and push it here.

@NiharR27
Copy link
Contributor

NiharR27 commented Jul 10, 2024

@thomaseizinger - I had to bump other packages in-order to run the command / build. Here is a PR that I created from my other account: https://github.com/thomaseizinger/create-release/pull/6/files.

We can close this PR once that one is good to go.

@NiharR027
Copy link
Author

Closing in favor of: #6

@NiharR027 NiharR027 closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants