Fix: Callbacks didn't clean up properly after .destroy()

therealPaulPlay · Jan 31, 2025 · 83bf0aa · 83bf0aa
1 parent 17f428d
commit 83bf0aa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "playpeerjs",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "WebRTC-based wrapper for creating robust peer-2-peer multiplayer systems with ease.",
   "type": "module",
   "main": "dist/playpeer.js",

diff --git a/src/index.js b/src/index.js
@@ -589,6 +589,9 @@ export default class PlayPeer {
                 this.#triggerEvent("destroy");
             }
 
+            // Clear intervals
+            clearInterval(this.#heartbeatSendInterval);
+
             // Resets
             this.#peer = undefined;
             this.#storage = {};
@@ -597,10 +600,7 @@ export default class PlayPeer {
             this.#hostConnectionsIdArray = [];
             this.#initialized = false;
             this.#maxSize = undefined;
-
-            // Clear intervals
-            clearInterval(this.#heartbeatSendInterval);
-            this.#triggerEvent("status", "Resetted internal data.");
+            this.#callbacks.clear();
         } catch (error) {
             console.error(ERROR_PREFIX + "Error during cleanup:", error);
             this.#triggerEvent("error", "Error during cleanup: " + error);