fix: clearer array update handling

therealPaulPlay · Jan 31, 2025 · 17f428d · 17f428d
1 parent 994be1f
commit 17f428d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "playpeerjs",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "WebRTC-based wrapper for creating robust peer-2-peer multiplayer systems with ease.",
   "type": "module",
   "main": "dist/playpeer.js",

diff --git a/src/index.js b/src/index.js
@@ -438,14 +438,12 @@ export default class PlayPeer {
      * @param {*} updateValue
      */
     #handleArrayUpdate(key, operation, value, updateValue) {
-        const updatedArray = this.#storage?.[key] || [];
-        if (!Array.isArray(this.#storage?.[key])) {
-            this.#storage[key] = []; // Ensure it's an array if it wasn't already
-        }
+        let updatedArray = this.#storage?.[key] || [];
+        if (!Array.isArray(this.#storage?.[key])) this.#storage[key] = []; // Ensure it's an array if it wasn't already
 
         switch (operation) {
             case 'add':
-                this.#storage[key].push(value);
+                updatedArray.push(value);
                 break;
 
             case 'add-unique':
@@ -458,13 +456,13 @@ export default class PlayPeer {
                 });
 
                 if (uniqueIndex == -1) {
-                    this.#storage[key].push(value); // Add the unique value
+                    updatedArray.push(value); // Add the unique value
                 }
                 break;
 
             case 'remove-matching':
                 // Remove matching value (deep comparison for objects)
-                this.#storage[key] = updatedArray.filter(item => {
+                updatedArray = updatedArray.filter(item => {
                     if (typeof value === 'object' && value !== null) {
                         return JSON.stringify(item) !== JSON.stringify(value);
                     }
@@ -482,7 +480,7 @@ export default class PlayPeer {
                 });
 
                 if (updateIndex > -1) {
-                    this.#storage[key][updateIndex] = updateValue; // Perform the update
+                    updatedArray[updateIndex] = updateValue; // Perform the update
                 }
                 break;
 
@@ -491,7 +489,7 @@ export default class PlayPeer {
                 this.#triggerEvent("error", `Unknown array operation: ${operation}`);
         }
 
-        this.#setStorageLocally(key, this.#storage[key]); // Update storage locally
+        this.#setStorageLocally(key, updatedArray); // Update storage locally
     }
 
     /**