Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Took TokenWriter implementation from jsoniter-scala #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Took TokenWriter implementation from jsoniter-scala #345

wants to merge 2 commits into from

Conversation

goshacodes
Copy link
Collaborator

@goshacodes goshacodes commented Feb 14, 2025 •
edited
Loading

  1. Implemented DefaultTokenWriter. (Copied very basics from jsoniter-scala with licences)
  2. Added jsoniter-scala to writer benchmarks
  3. Changed signature of TokenWriterProducer, so it could work not only for jackson. Changes are breaking for those who implement custom TokenWriterProducers.

@dos65 cc

@plokhotnyuk FYI. I hope this is fine, because jsoniter-scala has permissive MIT licence.

@goshacodes goshacodes force-pushed the default-performant-writer branch 3 times, most recently from cc153fb to b2a1c77 Compare February 15, 2025 07:12
@goshacodes goshacodes force-pushed the default-performant-writer branch from b2a1c77 to 6a7ddd1 Compare February 15, 2025 07:17
@goshacodes goshacodes added this to the 1.0.0 milestone Feb 15, 2025
@goshacodes
Copy link
Collaborator Author

Notes on this PR:

  1. Probably it will be better to add this as additional module, but leave everything in tethys package.
  2. This should be merged in new branch for 1.x series when we agree from which point we should start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core performance improvement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@goshacodes