Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(papyrus_base_layer): set port explicitly on anvil spawn #4489

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from c222bec to 8f00acd Compare February 27, 2025 08:38
@ArniStarkware ArniStarkware force-pushed the arni/base_layer/test/refactor_contract_creation branch from b6bdc22 to a927419 Compare February 27, 2025 09:40
@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 8f00acd to 3e7ca3e Compare February 27, 2025 09:40
@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 3e7ca3e to 1517f0d Compare February 27, 2025 13:28
@ArniStarkware ArniStarkware force-pushed the arni/base_layer/test/refactor_contract_creation branch 2 times, most recently from 66b25a2 to 72ab03d Compare March 2, 2025 06:53
@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 1517f0d to 9b4c974 Compare March 2, 2025 06:53
@ArniStarkware ArniStarkware changed the base branch from arni/base_layer/test/refactor_contract_creation to graphite-base/4489 March 2, 2025 06:59
@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 9b4c974 to 7b8a91f Compare March 2, 2025 06:59
@ArniStarkware ArniStarkware changed the base branch from graphite-base/4489 to arni/base_layer/base_layer_config_from_anvil March 2, 2025 06:59
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 7b8a91f to 731d94f Compare March 2, 2025 09:41
@ArniStarkware ArniStarkware force-pushed the arni/base_layer/base_layer_config_from_anvil branch from badfd7a to 531fde8 Compare March 2, 2025 09:41
@ArniStarkware ArniStarkware changed the base branch from arni/base_layer/base_layer_config_from_anvil to main March 2, 2025 10:44
@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 731d94f to 73ee814 Compare March 2, 2025 10:48
Copy link

graphite-app bot commented Mar 2, 2025

Merge activity

  • Mar 2, 5:49 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@ArniStarkware ArniStarkware force-pushed the arni/anvil/set_port_explicitly branch from 73ee814 to 0ad1807 Compare March 2, 2025 11:32
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@ArniStarkware ArniStarkware added this pull request to the merge queue Mar 2, 2025
Merged via the queue into main with commit 291e682 Mar 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants