Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(papyrus_base_layer): stongly link anvil with starknet_contract_address #4482

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@ArniStarkware ArniStarkware marked this pull request as ready for review February 26, 2025 08:02
Copy link
Contributor Author

ArniStarkware commented Feb 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase)


crates/papyrus_base_layer/Cargo.toml line 32 at r2 (raw file):

[dev-dependencies]
alloy = { workspace = true, features = ["node-bindings"] }

What is this for?

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArniStarkware and @giladchase)


crates/papyrus_base_layer/src/base_layer_test.rs line 59 at r2 (raw file):

    let anvil = anvil();
    let config = ethereum_base_layer_config_from_anvil(&anvil);

Suggestion:

ethereum_base_layer_config

@ArniStarkware ArniStarkware force-pushed the arni/base_layer/base_layer_config_from_anvil branch from badfd7a to 531fde8 Compare March 2, 2025 09:41
@ArniStarkware ArniStarkware requested a review from alonh5 March 2, 2025 09:42
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @giladchase)


crates/papyrus_base_layer/Cargo.toml line 32 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

What is this for?

Done.


crates/papyrus_base_layer/src/base_layer_test.rs line 59 at r2 (raw file):

    let anvil = anvil();
    let config = ethereum_base_layer_config_from_anvil(&anvil);

Done.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)

@ArniStarkware ArniStarkware added this pull request to the merge queue Mar 2, 2025
Merged via the queue into main with commit da4429f Mar 2, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants