-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(papyrus_base_layer): stongly link anvil with starknet_contract_address #4482
chore(papyrus_base_layer): stongly link anvil with starknet_contract_address #4482
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
792d28a
to
3fcd2ba
Compare
3fcd2ba
to
1d71e27
Compare
6ca3916
to
badfd7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase)
crates/papyrus_base_layer/Cargo.toml
line 32 at r2 (raw file):
[dev-dependencies] alloy = { workspace = true, features = ["node-bindings"] }
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArniStarkware and @giladchase)
crates/papyrus_base_layer/src/base_layer_test.rs
line 59 at r2 (raw file):
let anvil = anvil(); let config = ethereum_base_layer_config_from_anvil(&anvil);
Suggestion:
ethereum_base_layer_config
badfd7a
to
531fde8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @giladchase)
crates/papyrus_base_layer/Cargo.toml
line 32 at r2 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
What is this for?
Done.
crates/papyrus_base_layer/src/base_layer_test.rs
line 59 at r2 (raw file):
let anvil = anvil(); let config = ethereum_base_layer_config_from_anvil(&anvil);
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
No description provided.