-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(blockifier): use the jemalloc allocator for benchmark #3899
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
87ba54a
to
2eb41c4
Compare
587db2a
to
3d7f419
Compare
be509c9
to
ac9eee2
Compare
3d7f419
to
2e96006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/blockifier/bench/blockifier_bench.rs
line 17 at r1 (raw file):
use criterion::{criterion_group, criterion_main, Criterion}; // Note, it might be interesting to run this benchmark with and without the Jemalloc allocator.
Turn this into a TODO to consider.
Also, we're not currently running the bench in the CI right? We should probably add it right?
Code quote:
// Note, it might be interesting to run this benchmark with and without the Jemalloc allocator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/blockifier/bench/blockifier_bench.rs
line 17 at r1 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Turn this into a TODO to consider.
Also, we're not currently running the bench in the CI right? We should probably add it right?
Done.
About CI:
- We don't run this bench in CI.
- "Should we?" The same question can be asked about other benches in this repo. For example, the gateway bench.
- "If we want to do it - how should we do it?" We can do something similar to how they do it here:
crates/committer_cli/benches/bench_split_and_prepare_post.sh
.
ac9eee2
to
2eb7c41
Compare
2e96006
to
b0c1ba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
crates/blockifier/bench/blockifier_bench.rs
line 17 at r1 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
Done.
About CI:
- We don't run this bench in CI.
- "Should we?" The same question can be asked about other benches in this repo. For example, the gateway bench.
- "If we want to do it - how should we do it?" We can do something similar to how they do it here:
crates/committer_cli/benches/bench_split_and_prepare_post.sh
.
Okay I'll raise this question in the next sync
2eb7c41
to
3cc4297
Compare
b0c1ba3
to
8a473af
Compare
8a473af
to
ee04cc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 68 of 68 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
No description provided.