Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): use the jemalloc allocator for benchmark #3899

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/sequencer_node/hide_in_feature branch from 87ba54a to 2eb41c4 Compare February 3, 2025 09:02
@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/blockifier_bench/add_feature branch 2 times, most recently from 587db2a to 3d7f419 Compare February 3, 2025 09:13
@ArniStarkware ArniStarkware changed the base branch from arni/jemalloc/sequencer_node/hide_in_feature to arni/jemalloc/sequencer_node/set_global_on_main February 3, 2025 09:13
@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/sequencer_node/set_global_on_main branch from be509c9 to ac9eee2 Compare February 3, 2025 09:15
@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/blockifier_bench/add_feature branch from 3d7f419 to 2e96006 Compare February 3, 2025 09:16
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/blockifier/bench/blockifier_bench.rs line 17 at r1 (raw file):

use criterion::{criterion_group, criterion_main, Criterion};

// Note, it might be interesting to run this benchmark with and without the Jemalloc allocator.

Turn this into a TODO to consider.
Also, we're not currently running the bench in the CI right? We should probably add it right?

Code quote:

// Note, it might be interesting to run this benchmark with and without the Jemalloc allocator.

@ArniStarkware ArniStarkware requested a review from alonh5 February 3, 2025 13:37
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @alonh5)


crates/blockifier/bench/blockifier_bench.rs line 17 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Turn this into a TODO to consider.
Also, we're not currently running the bench in the CI right? We should probably add it right?

Done.

About CI:

  1. We don't run this bench in CI.
  2. "Should we?" The same question can be asked about other benches in this repo. For example, the gateway bench.
  3. "If we want to do it - how should we do it?" We can do something similar to how they do it here: crates/committer_cli/benches/bench_split_and_prepare_post.sh.

@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/sequencer_node/set_global_on_main branch from ac9eee2 to 2eb7c41 Compare February 3, 2025 13:37
@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/blockifier_bench/add_feature branch from 2e96006 to b0c1ba3 Compare February 3, 2025 13:37
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)


crates/blockifier/bench/blockifier_bench.rs line 17 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Done.

About CI:

  1. We don't run this bench in CI.
  2. "Should we?" The same question can be asked about other benches in this repo. For example, the gateway bench.
  3. "If we want to do it - how should we do it?" We can do something similar to how they do it here: crates/committer_cli/benches/bench_split_and_prepare_post.sh.

Okay I'll raise this question in the next sync

@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/sequencer_node/set_global_on_main branch from 2eb7c41 to 3cc4297 Compare February 3, 2025 13:47
@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/blockifier_bench/add_feature branch from b0c1ba3 to 8a473af Compare February 3, 2025 13:48
@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/blockifier_bench/add_feature branch from 8a473af to ee04cc7 Compare February 3, 2025 14:26
@ArniStarkware ArniStarkware changed the base branch from arni/jemalloc/sequencer_node/set_global_on_main to main February 3, 2025 14:26
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 68 of 68 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 728dacf Feb 3, 2025
23 of 40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants