Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_sequencer_node): set jemalloc as global allocator #3897

Merged

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Feb 3, 2025

@ArniStarkware
Copy link
Contributor Author

Blocking until we see a valid Python side PR.

@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/sequencer_node/set_global_on_main branch 2 times, most recently from be509c9 to ac9eee2 Compare February 3, 2025 09:15
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

@ArniStarkware
Copy link
Contributor Author

Previously, ArniStarkware (Arnon Hod) wrote…

Blocking until we see a valid Python side PR.

Python side passed!

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/jemalloc/sequencer_node/set_global_on_main branch from 2eb7c41 to 3cc4297 Compare February 3, 2025 13:47
@ArniStarkware ArniStarkware added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit c12c05c Feb 3, 2025
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants