Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update starkgate_function_reference.adoc #1081

Merged
merged 4 commits into from
Jan 21, 2024

Conversation

xiaolou86
Copy link
Contributor

@xiaolou86 xiaolou86 commented Jan 16, 2024

Description of the Changes

  1. Update starkgate's references

  2. Delete the L1 Constant MIN_DEPLOYMENT_FEE

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1081/documentation/ .

@xiaolou86
Copy link
Contributor Author

I can't find the L1 Constant MIN_DEPLOYMENT_FEE in any solidity, so I try to delete it...

Please tell me anything whether I am wrong or not.

@xiaolou86 xiaolou86 changed the title docs: Update starkgate_function_reference.adoc docs: update starkgate_function_reference.adoc Jan 16, 2024
@stoobie
Copy link
Collaborator

stoobie commented Jan 16, 2024

I can't find the L1 Constant MIN_DEPLOYMENT_FEE in any solidity, so I try to delete it...

Please tell me anything whether I am wrong or not.

@xiaolou86 You're correct that the constant MIN_DEPLOYMENT_FEE should be removed. The contract no longer includes that constant.

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1081/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1081/documentation/ .

@xiaolou86
Copy link
Contributor Author

Thank you very much, my bro @stoobie !

@stoobie stoobie merged commit 3857956 into main Jan 21, 2024
3 checks passed
@stoobie stoobie deleted the xiaolou86/update-starkgate branch January 21, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants