Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove info on removing a token #1079

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Jan 15, 2024

Description of the Changes

Remove info on removing a token.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1079/documentation/ .

@stoobie stoobie changed the title Remove selfRemove and Removing a token docs: Remove info on removing a token Jan 15, 2024
Copy link
Collaborator

@natan-granit natan-granit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoobie stoobie merged commit f215754 into main Jan 15, 2024
3 checks passed
@stoobie stoobie deleted the steve/StarkGate/delete_remove_token branch January 15, 2024 14:10
@xiaolou86
Copy link
Contributor

xiaolou86 commented Jan 15, 2024

@stoobie When I reviewed just now, I found that in the doc components/Starknet/modules/tools/pages/starkgate_function_reference.adoc

its reference page is 404 because can't find the repo https://github.com/starkware-libs/starkgate.
It will be better to update it and the others.

@stoobie
Copy link
Collaborator Author

stoobie commented Jan 15, 2024

its reference page is 404 because can't find the repo https://github.com/starkware-libs/starkgate.

@xiaolou86 Thanks for pointing this out!

@xiaolou86
Copy link
Contributor

@stoobie I will try to fix it when I have time.

@stoobie
Copy link
Collaborator Author

stoobie commented Jan 16, 2024

@stoobie I will try to fix it when I have time.

@xiaolou86 I think that the fix is just to comment out those links. I'll take care of it.

@xiaolou86
Copy link
Contributor

xiaolou86 commented Jan 16, 2024

@stoobie I will try to fix it when I have time.

@xiaolou86 I think that the fix is just to comment out those links. I'll take care of it.

@stoobie I have done and please help me to review #1081 It spent some time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants