Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html dev #3283

Merged
merged 4 commits into from
Mar 13, 2025
Merged

Html dev #3283

merged 4 commits into from
Mar 13, 2025
+27 −8

Conversation

nmccullagh-r7
Copy link
Collaborator

Tweak error handling

@nmccullagh-r7 nmccullagh-r7 requested a review from a team as a code owner March 13, 2025 12:12
@nmccullagh-r7 nmccullagh-r7 force-pushed the html-dev branch 4 times, most recently from 2fa19e1 to 51257d0 Compare March 13, 2025 12:41
dgreene-r7
dgreene-r7 reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@dgreene-r7 dgreene-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small notes. Also might be a good idea to add a unit test with an iframe that points to an external resource so we don't run into a regression somewhere down the road.

dgreene-r7
dgreene-r7 previously approved these changes Mar 13, 2025
View reviewed changes
@nmccullagh-r7 nmccullagh-r7 force-pushed the html-dev branch 2 times, most recently from 2aee965 to 610c978 Compare March 13, 2025 16:08
@nmccullagh-r7 nmccullagh-r7 changed the base branch from master to html-release-2.0.0 March 13, 2025 16:13
@nmccullagh-r7 nmccullagh-r7 merged commit 014b0a4 into html-release-2.0.0 Mar 13, 2025
11 of 12 checks passed
@nmccullagh-r7 nmccullagh-r7 deleted the html-dev branch March 13, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekelly-r7 ekelly-r7 ekelly-r7 approved these changes

@dgreene-r7 dgreene-r7 dgreene-r7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmccullagh-r7 @dgreene-r7 @ekelly-r7