[HTML] Error tweaks

nmccullagh-r7 · nmccullagh-r7 · commit f63761e862ca · 2025-03-13T16:10:46.000Z
diff --git a/plugins/html/.CHECKSUM b/plugins/html/.CHECKSUM
@@ -1,7 +1,7 @@
 {
 	"spec": "33f280644876cd71ba4112869461350c",
 	"manifest": "1c932692c9520b9afab8ff4b3502b315",
-	"setup": "8113ed9080eb31cffbf3ebacb5bbe04a",
+	"setup": "e6dd8f0161c12fc73e44451284b9ecb8",
 	"schemas": [
 		{
 			"identifier": "docx/schema.py",
diff --git a/plugins/html/icon_html/util/helpers.py b/plugins/html/icon_html/util/helpers.py
@@ -1,10 +1,11 @@
 import base64
 import os
 import uuid
-from typing import Union
 
 import pypandoc
 import structlog
+from insightconnect_plugin_runtime.exceptions import PluginException
+from typing import Union
 
 from icon_html.util.constants import DEFAULT_ENCODING
 
@@ -53,7 +54,11 @@ def convert_with_temporary_file(
     except Exception as e:
         log = structlog.getLogger("action logger")
         log.error("failed to execute action step", file_name=file_name, exception=e)
-        raise e
+        raise PluginException(
+            cause="failed to execute step",
+            assistance="Check the plugin logs. If executing in the cloud, ensure html tags are not linking to resources on the internet.",
+            data=e,
+        )
     finally:
         delete_file(file_name)
 
diff --git a/plugins/html/unit_test/test_markdown.py b/plugins/html/unit_test/test_markdown.py
@@ -47,11 +47,25 @@ def test_html_with_header_tags(self):
             "UmFwaWQ3IEluc2lnaHRDb25uZWN0Cj09PT09PT09PT09PT09PT09PT09PQoKQ29udmVydCBIVE1MIHRvIE1hcmtkb3duCg==",
         )
 
-    def test_action_empty_string(self):
-        params = {"doc": " "}
+    def test_markdown_cloud(self):
+        params = {
+            "doc": '<!DOCTYPE html><html><iframe src="https://www.google.com"></iframe></html>'
+        }
 
+        os.environ["PLUGIN_RUNTIME_ENVIRONMENT"] = "cloud"
         test_action = Markdown()
+        result = test_action.run(params)
+        del os.environ["PLUGIN_RUNTIME_ENVIRONMENT"]
+
+        self.assertEqual(result["markdown_file"], "Cg==")
+        self.assertEqual(result["markdown_contents"], "\n")
+
+
+def test_action_empty_string(self):
+    params = {"doc": " "}
+
+    test_action = Markdown()
 
-        with self.assertRaises(PluginException) as context:
-            test_action.run(params)
-        self.assertEqual(context.exception.cause, "Invalid input.")
+    with self.assertRaises(PluginException) as context:
+        test_action.run(params)
+    self.assertEqual(context.exception.cause, "Invalid input.")

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"spec": "33f280644876cd71ba4112869461350c",`
`3`	`3`	`"manifest": "1c932692c9520b9afab8ff4b3502b315",`
`4`		`- "setup": "8113ed9080eb31cffbf3ebacb5bbe04a",`
	`4`	`+ "setup": "e6dd8f0161c12fc73e44451284b9ecb8",`
`5`	`5`	`"schemas": [`
`6`	`6`	`{`
`7`	`7`	`"identifier": "docx/schema.py",`