Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qiime info to show parallel config info #340

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jul 10, 2024

Adds info about the current parallel config to qiime info

blocked by qiime2/qiime2#775

@Oddant1 Oddant1 added the stat:blocked This cannot be resolved until something else has changed. label Jul 10, 2024
@Oddant1 Oddant1 self-assigned this Jul 10, 2024
@Oddant1 Oddant1 assigned gregcaporaso and ebolyen and unassigned Oddant1 Jul 18, 2024
@Oddant1 Oddant1 requested review from gregcaporaso and ebolyen July 18, 2024 23:12
@ebolyen ebolyen assigned Oddant1 and unassigned gregcaporaso and ebolyen Jul 22, 2024
@ebolyen
Copy link
Member

ebolyen commented Jul 22, 2024

Looks like there's some merge conflicts now

@Oddant1 Oddant1 removed the stat:blocked This cannot be resolved until something else has changed. label Jul 22, 2024
@Oddant1
Copy link
Member Author

Oddant1 commented Jul 22, 2024

@ebolyen the tests here aren't pulling the version of the framework with the necessary PR merged. They pass locally.

Copy link
Member

@gregcaporaso gregcaporaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions on this. I pulled it down and tested locally, and it all looks right to me.

@Oddant1
Copy link
Member Author

Oddant1 commented Aug 1, 2024

@gregcaporaso I have updated the link to https://develop.qiime2.org/en/latest/framework/how-to-guides/parallel-configuration.html for now and opened an issue saying to change it when the docs are actually out.

@Oddant1 Oddant1 assigned gregcaporaso and ebolyen and unassigned Oddant1 Aug 8, 2024
@gregcaporaso gregcaporaso merged commit 843ab24 into qiime2:dev Aug 14, 2024
4 checks passed
@gregcaporaso
Copy link
Member

Thanks again for the work on this one @oddant!

@lizgehret lizgehret assigned Oddant1 and unassigned gregcaporaso and ebolyen Aug 15, 2024
@Oddant1 Oddant1 removed their assignment Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants