Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin level citations to the action --citation flag #339

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Add plugin level citations to the action --citation flag #339

merged 3 commits into from
Jul 22, 2024

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jun 27, 2024

Closes #336

@Oddant1 Oddant1 self-assigned this Jun 27, 2024
@Oddant1 Oddant1 requested a review from gregcaporaso June 27, 2024 19:23
@ebolyen ebolyen assigned gregcaporaso and unassigned Oddant1 Jul 3, 2024
gregcaporaso
gregcaporaso approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@gregcaporaso gregcaporaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Oddant1. I also tested locally with an example like the one I described in #336 and it all works as expected.

@gregcaporaso gregcaporaso merged commit faa134b into qiime2:dev Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcaporaso gregcaporaso gregcaporaso approved these changes

Assignees

@gregcaporaso gregcaporaso

Labels
None yet
Projects
No open projects
2024.10 🎃
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--citations should report plugin citations when called on an action
2 participants
@Oddant1 @gregcaporaso