Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip size_test binaries and report their sizes in build_size_test.sh #9633

Closed
wants to merge 1 commit into from
Closed

Strip size_test binaries and report their sizes in build_size_test.sh #9633

wants to merge 1 commit into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 25, 2025 •
edited
Loading

No description provided.

@swolchok
Update
4de8e3d 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9633

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4de8e3d with merge base 811352d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 25, 2025
@swolchok
Strip size_test binaries and report their sizes in build_size_test.sh
ff22429 
ghstack-source-id: 5474710345a2a2712c47265b4428a886c6867438
ghstack-comment-id: 2752782870
Pull-Request-resolved: #9633
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2025
This was referenced Mar 25, 2025
Merged
Merged
Closed
@swolchok
Copy link
Contributor Author

this doesn't support the workflow I want after all, abandoning.

@swolchok swolchok closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swolchok @facebook-github-bot