elementwise_util: s/common/compute/ almost everywhere and deprecate SAME_AS_COMPUTE #9613
+123
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9613
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit aab3e03 with merge base 811352d ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
…AME_AS_COMMON As the title says, this is mostly a few related find-replaces, plus marking SupportedTensorDtypes::SAME_AS_COMMON deprecated. ghstack-source-id: 96ac25a9a2d2dc5b72a7e813f2c53c6a3966228a ghstack-comment-id: 2752741465 Pull-Request-resolved: #9613
facebook-github-bot
added
the
CLA Signed
swolchok
changed the title
|
I'm not sure of the best way to handle SAME_AS_COMMON/SAME_AS_COMPUTE. The problems are as follows:
|
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
As the code comment says, these APIs are undergoing development (see e.g. #9613) and it's pretty inconvenient that they're incidentally committed-to externally. Mark them deprecated so we have the option to drop that commitment in (IIUC) 0.7. ghstack-source-id: f9ea4ab39bd8c9ce4a8ebf7ec7c66b9b51da3079 ghstack-comment-id: 2752758912 Pull-Request-resolved: #9621
This was referenced Mar 25, 2025
swolchok
added
the
release notes: api
|
we should land this if and only if @manuelcandales agrees it is improving the code, since the diffs I was trying to support with it have been abandoned. |
manuelcandales
approved these changes
Mar 26, 2025
swolchok
added a commit
that referenced
this pull request
Mar 26, 2025
As the code comment says, these APIs are undergoing development (see e.g. #9613) and it's pretty inconvenient that they're incidentally committed-to externally. Mark them deprecated so we have the option to drop that commitment in (IIUC) 0.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this is mostly a few related find-replaces, plus marking SupportedTensorDtypes::SAME_AS_COMPUTE deprecated.