Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyTorch pin to 2025-03-25 #9578

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Bump PyTorch pin to 2025-03-25 #9578

wants to merge 13 commits into from

Conversation

swolchok
Copy link
Contributor

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 25, 2025

Copy link

pytorch-bot bot commented Mar 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9578

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs

As of commit bbf612c with merge base ce74f8e (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2025
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this after our branch cut on Wednesday 6pm?

The reason is that 3-12 is the RC candidate for PT2.7 - anything after that is in the PT2.8

Otherwise, we would have to go back and forth, instead of monotonically increasing the nightly.

@mergennachin
Copy link
Contributor

Unfortunately, this is the downside of delaying the branch cut and diverging from pytorch timeline

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/393/head to main March 26, 2025 20:57
@swolchok swolchok requested a review from mergennachin March 27, 2025 19:44
@swolchok
Copy link
Contributor Author

@mergennachin the branch is cut now, right?

[ghstack-poisoned]
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience, we can move forward now that its post branch cut

@mergennachin
Copy link
Contributor

cc @metascroy

@swolchok
Copy link
Contributor Author

looks like unittest-arm failure are new, CC @digantdesai

[ghstack-poisoned]
@swolchok swolchok requested a review from digantdesai as a code owner March 27, 2025 21:44
@swolchok
Copy link
Contributor Author

resnapshotted the ARM test. we'll see if it builds.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

pinged @digantdesai for advice on how to proceed with ARM failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants