Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample input for new core op elu.out #9577

Merged
merged 7 commits into from
Mar 26, 2025
Merged

Conversation

swolchok
Copy link
Contributor

I have no idea what this file actually does, but it seems like we are supposed to have this?

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 25, 2025

Copy link

pytorch-bot bot commented Mar 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9577

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2c5ee5f with merge base c43d5ad (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2025
Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is for input dtype regulation for every operator in edge dialect.

@swolchok
Copy link
Contributor Author

btw I can't run exir/dialects/edge/spec/gen.py to update the yaml file. error:

Can not find operator schema for aten::_log_softmax
Traceback (most recent call last):
  File "/Users/swolchok/src/executorch/exir/dialects/edge/spec/gen.py", line 524, in <module>
    main()
    ~~~~^^
  File "/Users/swolchok/src/executorch/exir/dialects/edge/spec/gen.py", line 519, in main
    unsupported_funcs = gen_edge_yaml(op_names, stream)
  File "/Users/swolchok/src/executorch/exir/dialects/edge/spec/gen.py", line 480, in gen_edge_yaml
    ret = gen_op_yaml(op_name)
  File "/Users/swolchok/src/executorch/exir/dialects/edge/spec/gen.py", line 425, in gen_op_yaml
    raise e
  File "/Users/swolchok/src/executorch/exir/dialects/edge/spec/gen.py", line 420, in gen_op_yaml
    func_schema: torch._C.FunctionSchema = get_callable(op_name)._schema
                                           ~~~~~~~~~~~~^^^^^^^^^
  File "/Users/swolchok/src/executorch/exir/dialects/edge/op/api.py", line 33, in get_callable
    main, suffix = name.split(".")
    ^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 1)

seems like maybe log_softmax shoudld be log_softmax.out?

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/390/head to main March 26, 2025 20:26
@swolchok
Copy link
Contributor Author

can't run exir/dialects/edge/spec/gen.py

For posterity, I had forgotten to pass --regenerate.

@swolchok swolchok merged commit 12240cf into main Mar 26, 2025
82 checks passed
@swolchok swolchok deleted the gh/swolchok/393/head branch March 26, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants