-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMY loading improvements #7
Conversation
I added an underscore to the start of all http://wholmgren-pvlib-python-new.readthedocs.org/en/tmyurl/pvlib.html#module-pvlib.tmy I think that I've now added tests for all of the new behavior and I've implemented Note that the year coercion is disabled by default. I chose this behavior because I think that this follows the principle of least surprise. |
Good point. I added the
|
Updated to fix a documentation issue mentioned in #16. Anything else to do here before merging? |
Looks good. I think this can be merged. Should I merge or wait for other comments? |
I think you can go ahead and merge this one. |
Shall we add standard readers for typical data providers such as:
OK, maybe this is more a candidate for a separate model like pylib.io |
I would like to have these readers too, but I think you should open a new issue and propose this. |
Adds ability to open TMY3 files via a url.
Closes #5
Cleans up some other aspects of the module including unneeded imports, slightly improved documentation.
Not yet ready for merging as it still needs new tests andcoerce_year
is not yet implemented.