Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue17 #23

Merged
merged 1 commit into from
Mar 10, 2015
Merged

Issue17 #23

merged 1 commit into from
Mar 10, 2015

Conversation

jforbess
Copy link
Contributor

Only cosmetic changes. Note that Location refers to tz as a string, while the TMY meta creates TZ as a float. To be resolved in 0.2.

@wholmgren
Copy link
Member

Thanks. The only thing is that we can easily merge the pvsystem.py commit 995f6a9 but I think that the tmy.py commit b31e6bf is going to conflict with the many tmy changes in #7. So, can you update your PR to just have 995f6a9?

Addresses #17 and #15.

@jforbess
Copy link
Contributor Author

Ok, I removed the last commit, so no changes to tmy.py. I think it's good to go.

wholmgren added a commit that referenced this pull request Mar 10, 2015
@wholmgren
Merge pull request #23 from jforbess/issue17
e7a2578 
Issue17
@wholmgren wholmgren merged commit e7a2578 into pvlib:master Mar 10, 2015
@wholmgren
Copy link
Member

Great, thank you!

@bmu bmu added this to the 0.1 milestone Mar 12, 2015
@jforbess jforbess deleted the issue17 branch July 12, 2015 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jforbess @wholmgren @bmu