Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISC fixes #26

Merged
merged 3 commits into from
Mar 12, 2015
Merged

DISC fixes #26

merged 3 commits into from
Mar 12, 2015

Conversation

wholmgren
Copy link
Member

Note the small API changes.

Could be some merge issues with #22. I'll take care of that if it happens.

@wholmgren
Copy link
Member Author

Here's some sample output. Not sure what the cause of the errors in the first diagram is since I haven't used this algorithm very much. Maybe airmass and clear sky model mismatches? I did check the Python code against PVLIB_MATLAB 1.2 and it looks ok.

tus = Location(32.2, -111, 'MST', 700)
tus_pressure = pvlib.atmosphere.alt2pres(700)
times = pd.date_range(start=datetime.datetime(2014,6,24), end=datetime.datetime(2014,6,25), freq='1Min')
solpos = pvlib.solarposition.get_solarposition(times, tus, method='pyephem')
tus_cs = pvlib.clearsky.ineichen(times, tus)
ax = tus_cs.plot(figsize=(8,6))
DNI = pvlib.clearsky.disc(tus_cs.GHI, solpos.zenith, solpos.index, pressure=tus_pressure)
DNI.DNI_gen_DISC.plot(ax=ax, legend=True)

ryra1arazig80uutvp0ran ryekqaaagrjrefugssyt1tk3b3hsqcrqctls1jl5flfnru52cwdu m4jupkja5b8tvxhmdxngzgzt1xhmdxcoy7d8dxhmfjge7chcdxhcdnuhn3hmdxnjzhzt1xhmdxcoy7d8dxhmfjgf8pmcyi0af bo0aaaaasuvork5cyii

tus = Location(32.2, -111, 'MST', 700)
tus_pressure = pvlib.atmosphere.alt2pres(700)
times = pd.date_range(start=datetime.datetime(2014,1,24), end=datetime.datetime(2014,1,25), freq='1Min')
solpos = pvlib.solarposition.get_solarposition(times, tus, method='pyephem')
tus_cs = pvlib.clearsky.ineichen(times, tus)
ax = tus_cs.plot(figsize=(8,6))
DNI = pvlib.clearsky.disc(tus_cs.GHI, solpos.zenith, solpos.index, pressure=tus_pressure)
DNI.DNI_gen_DISC.plot(ax=ax, legend=True)

xj0k0xfozwgb8tgbck3rndpaxyox54tdlsgar2dlvji3g hzcnyys9l3nmbukzy74wh8j95mtvobts5wx7bpxkv25i9jozf8ixedlx0rk842lryval2q3azlbgo5tdlemtvonpd8qyt6xt4z5ijplbzopiqulqjpj9ynzlfjduuccsiuqierltturripfijbkjypak90qikugkiimv7oleipfireyq3bojrckriixuuccsiuqiermpce8k

@bmu bmu added this to the 0.1 milestone Mar 12, 2015
robwandrews added a commit that referenced this pull request Mar 12, 2015
@robwandrews robwandrews merged commit 4868069 into pvlib:master Mar 12, 2015
@robwandrews
Copy link
Contributor

Interesting, it looks like the algorithm is good, but there might be some science to look at the difference in the algorithms. Looks good for a merge.

@robwandrews robwandrews mentioned this pull request Mar 12, 2015
@wholmgren wholmgren deleted the disc branch October 28, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants