Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dirint function #4

Closed
robwandrews opened this issue Feb 17, 2015 · 5 comments · Fixed by #44
Closed

fix dirint function #4

robwandrews opened this issue Feb 17, 2015 · 5 comments · Fixed by #44
Labels
bug
Milestone
0.1

Comments

@robwandrews
Copy link
Contributor

similar to Sandia-Labs/PVLIB_Python#40 , ensure compatibility in the new package
@bmu bmu added the bug label Mar 12, 2015
@bmu bmu added this to the 0.1 milestone Mar 12, 2015
@wholmgren
Copy link
Member

Wondering if this is going to make it into 0.1 and if so, who is going to do it. I would consider implementing it for 0.2, but I can't do it in the 0.1 time frame.

@robwandrews
Copy link
Contributor Author

@wholmgren , is this completed with #26 ?

@wholmgren
Copy link
Member

No, that PR just addressed the issues with the DISC function.

@robwandrews
Copy link
Contributor Author

Right, lets shift this to 0.2 for the dirint function.

@robwandrews robwandrews modified the milestones: 0.2, 0.1 Mar 12, 2015
@wholmgren
Copy link
Member

PVLIB MATLAB 1.2 has a lot more GHI to DNI functions:

* pvl_louche
* pvl_orgill_hollands
* pvl_erbs
* pvl_reindl_1
* pvl_reindl_2

Not sure if we want to rename this issue to encompass the implementation of all of these algorithms or if we should just put this in #2.

This was referenced Mar 27, 2015
Closed
Merged
@bmu bmu closed this as completed in #44 Apr 4, 2015
@bmu bmu modified the milestones: 0.1, 0.2 Apr 22, 2015
AdamRJensen added a commit that referenced this issue Dec 20, 2023
@lorenzo-solcast @cwhanse
@AdamRJensen @hugh-solcast
add functionality to load Solcast API data to iotools (#1875)
da4110f 
* prototype (#1)

* first iteration

* dynamic period

* docstring

* feedback

* linting

* Update pvlib/iotools/solcast.py

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* Update pvlib/iotools/solcast.py

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* Update pvlib/iotools/solcast.py

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* midpoint docstring

* flak8 formatting

* PR 1875 (#2)

* kandersolar feedback (#3)

* addressing feedback from Kandersolar

* Review (#4)

added hack for ISO periods in Pandas 0.25 and clearsky parameter maps

* comment on pandas version

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Adams's feedback

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Adams's feedback

* Last minor changes

* added test for _get_solcast

* feat: add additional test coverage (#5)

Co-authored-by: Hugh Cutcher <hugh@solcast.com.au>

* linting

---------

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: hugh-solcast <143680553+hugh-solcast@users.noreply.github.com>
Co-authored-by: Hugh Cutcher <hugh@solcast.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

implement dirint wholmgren/pvlib-python
3 participants
@bmu @robwandrews @wholmgren