Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Dispatch ChunkedArray serialization to Series (IPC) serialization #21422

Merged
merged 2 commits into from
Feb 24, 2025
Merged

refactor(rust): Dispatch ChunkedArray serialization to Series (IPC) serialization #21422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d6787
c
nameexhaustion Feb 23, 2025
92067c3
c
nameexhaustion Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 4 additions & 186 deletions crates/polars-core/src/serde/chunked_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,12 @@
use std::cell::RefCell;

use serde::ser::{Error, SerializeMap};
use serde::{Serialize, Serializer};

use crate::chunked_array::flags::StatisticsFlags;
use crate::prelude::*;
use crate::series::implementations::null::NullChunked;

pub struct IterSer<I>
where
I: IntoIterator,
<I as IntoIterator>::Item: Serialize,
{
iter: RefCell<Option<I>>,
}

impl<I> IterSer<I>
where
I: IntoIterator,
<I as IntoIterator>::Item: Serialize,
{
fn new(iter: I) -> Self {
IterSer {
iter: RefCell::new(Some(iter)),
}
}
}

impl<I> Serialize for IterSer<I>
where
I: IntoIterator,
<I as IntoIterator>::Item: Serialize,
{
fn serialize<S>(
&self,
serializer: S,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
S: Serializer,
{
let iter: I = self.iter.borrow_mut().take().unwrap();
serializer.collect_seq(iter)
}
}

fn serialize_impl<T, S>(
serializer: S,
name: &PlSmallStr,
dtype: &DataType,
bit_settings: StatisticsFlags,
ca: &ChunkedArray<T>,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
T: PolarsNumericType,
T::Native: Serialize,
S: Serializer,
{
let mut state = serializer.serialize_map(Some(4))?;
state.serialize_entry("name", name)?;
state.serialize_entry("datatype", dtype)?;
state.serialize_entry("bit_settings", &bit_settings)?;
state.serialize_entry("values", &IterSer::new(ca.iter()))?;
state.end()
}

// We don't use this internally (we call Series::serialize instead), but Rust users might need it.
impl<T> Serialize for ChunkedArray<T>
where
T: PolarsNumericType,
T::Native: Serialize,
{
fn serialize<S>(
&self,
serializer: S,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
S: Serializer,
{
serialize_impl(
serializer,
self.name(),
self.dtype(),
self.get_flags(),
self,
)
}
}

impl<K: PolarsDataType, T: PolarsNumericType> Serialize for Logical<K, T>
where
Self: LogicalType,
ChunkedArray<T>: Serialize,
T::Native: Serialize,
T: PolarsDataType,
ChunkedArray<T>: IntoSeries,
{
fn serialize<S>(
&self,
Expand All @@ -99,104 +15,6 @@ where
where
S: Serializer,
{
serialize_impl(
serializer,
self.name(),
self.dtype(),
self.get_flags(),
self,
)
}
}

macro_rules! impl_serialize {
($ca: ident) => {
impl Serialize for $ca {
fn serialize<S>(
&self,
serializer: S,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
S: Serializer,
{
let mut state = serializer.serialize_map(Some(4))?;
state.serialize_entry("name", self.name())?;
state.serialize_entry("datatype", self.dtype())?;
state.serialize_entry("bit_settings", &self.get_flags())?;
state.serialize_entry("values", &IterSer::new(self.into_iter()))?;
state.end()
}
}
};
}

impl_serialize!(StringChunked);
impl_serialize!(BooleanChunked);
impl_serialize!(ListChunked);
impl_serialize!(BinaryChunked);
#[cfg(feature = "dtype-array")]
impl_serialize!(ArrayChunked);

#[cfg(feature = "dtype-categorical")]
impl Serialize for CategoricalChunked {
fn serialize<S>(
&self,
serializer: S,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
S: Serializer,
{
{
let mut state = serializer.serialize_map(Some(4))?;
state.serialize_entry("name", self.name())?;
state.serialize_entry("datatype", self.dtype())?;
state.serialize_entry("bit_settings", &self.get_flags())?;
state.serialize_entry("values", &IterSer::new(self.iter_str()))?;
state.end()
}
}
}

#[cfg(feature = "dtype-struct")]
impl Serialize for StructChunked {
fn serialize<S>(
&self,
serializer: S,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
S: Serializer,
{
{
if self.null_count() > 0 {
return Err(S::Error::custom(
"serializing struct with outer validity not yet supported",
));
}

let mut state = serializer.serialize_map(Some(4))?;
state.serialize_entry("name", self.name())?;
state.serialize_entry("datatype", self.dtype())?;
state.serialize_entry("length", &self.len())?;
state.serialize_entry("values", &self.fields_as_series())?;
state.end()
}
}
}

impl Serialize for NullChunked {
fn serialize<S>(
&self,
serializer: S,
) -> std::result::Result<<S as Serializer>::Ok, <S as Serializer>::Error>
where
S: Serializer,
{
{
let mut state = serializer.serialize_map(Some(3))?;
state.serialize_entry("name", self.name())?;
state.serialize_entry("datatype", self.dtype())?;
state.serialize_entry("values", &IterSer::new(std::iter::once(self.len())))?;
state.end()
}
self.clone().into_series().serialize(serializer)
}
}
Loading