refactor(rust): Dispatch ChunkedArray serialization to Series (IPC) serialization #21422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21422 +/- ##
==========================================
+ Coverage 79.96% 80.01% +0.04%
==========================================
Files 1597 1597
Lines 229115 228999 -116
Branches 2618 2618
==========================================
+ Hits 183222 183227 +5
+ Misses 45294 45173 -121
Partials 599 599 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
|
Nice one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully removes older serialization code for ChunkedArrays - they were no longer used since we moved to using IPC for serde.
Note that we don't directly call serialize on ChunkedArrays internally at all - it can be completely removed, but I have made it a dispatch instead in case there were Rust library users dependent on this.