-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(python): Make torch
install CI-only by default
#16058
tests(python): Make torch
install CI-only by default
#16058
Conversation
torch
tests CI-only, defaulting to optional install of such packagestorch
install CI-only, defaulting to optional install of such packages
torch
install CI-only, defaulting to optional install of such packagestorch
install CI-only by default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16058 +/- ##
==========================================
- Coverage 80.97% 80.93% -0.05%
==========================================
Files 1386 1386
Lines 178382 178382
Branches 3059 3059
==========================================
- Hits 144446 144372 -74
- Misses 33448 33522 +74
Partials 488 488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b106590
to
521ab69
Compare
521ab69
to
23efd34
Compare
23efd34
to
e42e9f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex!
Streamlining the default dev environment...
torch
package from "requirements-dev.txt" to new "requirements-ci.txt".polars.ml.torch
with/without localtorch
install.third_party_integration
marker toci_only
to better describe its purpose.make requirements-all
command that installs the usual dev packages and the "CI only" packages.torch
import in the "test_to_torch" unit tests lazy-load so that optional absence of the package doesn't causepytest
to complain when run locally (the CI runner will always have it installed, so no issue there).We might want to make a couple of other packages CI-only by default, but for now this only covers the new
torch
integrations.