Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(python): Mark iceberg tests/requirements "ci-only" and make some related user guide updates #16133

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 9, 2024

Ref: #16058.

Marks the iceberg tests/deps "ci-only", ensures that lint succeeds with/without the pyiceberg package installed, and includes some user guide additions to note the existence of make requirements and make requirements-all.

@github-actions github-actions bot added the internal An internal refactor or improvement label May 9, 2024
@alexander-beedie alexander-beedie added ci Related to the continuous integration setup test Related to the test suite labels May 9, 2024
@alexander-beedie alexander-beedie marked this pull request as draft May 9, 2024 09:59
@alexander-beedie alexander-beedie force-pushed the additional-ci-only-packages branch from 835fd83 to 9aebc7b Compare May 9, 2024 10:13
@alexander-beedie alexander-beedie marked this pull request as ready for review May 9, 2024 10:14
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (12b40b9) to head (9aebc7b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16133   +/-   ##
=======================================
  Coverage   80.95%   80.96%           
=======================================
  Files        1386     1386           
  Lines      178434   178438    +4     
  Branches     2878     2882    +4     
=======================================
+ Hits       144455   144471   +16     
+ Misses      33487    33473   -14     
- Partials      492      494    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 44852b4 into pola-rs:main May 9, 2024
18 checks passed
@alexander-beedie alexander-beedie deleted the additional-ci-only-packages branch May 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to the continuous integration setup internal An internal refactor or improvement test Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants