fix(json): Add backslash to unescaped character list (facebookincubat…

…or#12442) Summary: facebookincubator#12389 Fix json_parse error due to lacking switch case for backslash. Differential Revision: D70132773
peterenescu · Feb 25, 2025 · 2412aa4 · 2412aa4
1 parent b0d7de9
commit 2412aa4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/velox/functions/prestosql/json/JsonStringUtil.cpp b/velox/functions/prestosql/json/JsonStringUtil.cpp
@@ -262,6 +262,9 @@ int32_t getEscapedChar(std::string_view view, size_t& pos) {
       case 't':
         pos += 2;
         return '\t';
+      case '\\':
+        pos += 2;
+        return '\\';
 
       default:
         // Presto java ignores bad escape sequences.

diff --git a/velox/functions/prestosql/tests/JsonFunctionsTest.cpp b/velox/functions/prestosql/tests/JsonFunctionsTest.cpp
@@ -231,6 +231,7 @@ TEST_F(JsonFunctionsTest, jsonParse) {
   EXPECT_EQ(jsonParse(R"(["k1", "v1"])"), R"(["k1","v1"])");
   testJsonParse(R"({ "abc" : "\/"})", R"({"abc":"/"})");
   testJsonParse(R"({ "abc" : "\\/"})", R"({"abc":"\\/"})");
+  testJsonParse("{\"\\\\\":null, \"\\\\\":null}", R"({"\\":null,"\\":null})");
   testJsonParse(R"({ "abc" : [1, 2, 3, 4    ]})", R"({"abc":[1,2,3,4]})");
   // Test out with unicodes and empty keys.
   testJsonParse(