Skip to content

Commit b0d7de9

Browse files
kagamiorifacebook-github-bot
authored andcommitted
misc(fuzzer): Enable aggregation fuzzer test with FB-only functions (facebookincubator#12288)
Summary: Pull Request resolved: facebookincubator#12288 This diff also removes LogicalDummyScan from velox/parse/DuckLogicalOperator.h because this symbol already exists in duckdb/planner/operator/logical_dummy_scan.hpp which causes a linking error due to duplicate symbols Reviewed By: kgpai Differential Revision: D68338748 fbshipit-source-id: c57e7c7f0d49400d7329f643eb381e46147b5bc8
1 parent 4787a99 commit b0d7de9

File tree

3 files changed

+3
-26
lines changed

3 files changed

+3
-26
lines changed

velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ DEFINE_uint32(
6464
"Timeout in milliseconds for HTTP requests made to reference DB, "
6565
"such as Presto. Example: --req_timeout_ms=2000");
6666

67+
// Any change made in the file should be reflected in
68+
// the FB-internal aggregation fuzzer test too:
6769
namespace facebook::velox::exec::test {
6870
namespace {
6971

velox/parse/DuckLogicalOperator.h

-26
Original file line numberDiff line numberDiff line change
@@ -48,32 +48,6 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
4848
/// of DuckDB.
4949
namespace duckdb {
5050

51-
//! LogicalDummyScan represents a dummy scan returning a single row
52-
class LogicalDummyScan : public LogicalOperator {
53-
public:
54-
explicit LogicalDummyScan(idx_t table_index)
55-
: LogicalOperator(LogicalOperatorType::LOGICAL_DUMMY_SCAN),
56-
table_index(table_index) {}
57-
58-
idx_t table_index;
59-
60-
public:
61-
vector<ColumnBinding> GetColumnBindings() override {
62-
return {ColumnBinding(table_index, 0)};
63-
}
64-
65-
idx_t EstimateCardinality(ClientContext& context) override {
66-
return 1;
67-
}
68-
69-
protected:
70-
void ResolveTypes() override {
71-
if (types.size() == 0) {
72-
types.emplace_back(LogicalType::INTEGER);
73-
}
74-
}
75-
};
76-
7751
//! LogicalGet represents a scan operation from a data source
7852
class LogicalGet : public LogicalOperator {
7953
public:

velox/parse/QueryPlanner.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include <duckdb/planner/expression/bound_constant_expression.hpp> // @manual
2828
#include <duckdb/planner/expression/bound_function_expression.hpp> // @manual
2929
#include <duckdb/planner/expression/bound_reference_expression.hpp> // @manual
30+
#include <duckdb/planner/operator/logical_dummy_scan.hpp> // @manual
3031

3132
namespace facebook::velox::core {
3233

0 commit comments

Comments
 (0)