Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More manual pagination #7763

Open
wants to merge 2 commits into
base: paginated-manually
Choose a base branch
from
Open

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Mar 7, 2025

Continuing #7717

@davepacheco
Copy link
Collaborator

Did you plan to land this change or is this more of an experiment to see if we could get rid of paginated_multicolumn? FWIW #7717 makes sense to me because we didn't have a way to do that and I agree that expanding this family of functions sounds...awful. I'm less sure it's worth getting rid of paginated_multicolumn given that we have it.

@smklein
Copy link
Collaborator Author

smklein commented Mar 8, 2025

Did you plan to land this change or is this more of an experiment to see if we could get rid of paginated_multicolumn? FWIW #7717 makes sense to me because we didn't have a way to do that and I agree that expanding this family of functions sounds...awful. I'm less sure it's worth getting rid of paginated_multicolumn given that we have it.

It's a little bit of both - I wanted to see what this change would look like more broadly, and also wanted to measure at some point to see the impact on compile time, since paginated_multicolumn has fairly complex trait bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants