Refactor raw paginator for affinity specifically #7851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
commented
Mar 21, 2025
| @@ -88,14 +88,14 @@ type BoxedQuery = diesel::query_builder::BoxedSqlQuery< | |||
| // | |||
| // But this relies on nightly features. | |||
| pub struct QueryBuilder { | |||
There was a problem hiding this comment.
It was really difficult to write helper logic around this interface with a self-consuming API.
Changing the API to act on &mut self made this much more possible, but required minor refactors to existing users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some of the "raw pagination" logic into
RawPaginator, to help de-duplicate paginationlogic in cases that too complex (e.g., the result of JOINs, UNIONs) for the existing Diesel pagination
tools.