-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include backtrace from omdb panic from within omdb tests #6516
Conversation
With just the first commit, tests fail with:
This is where I learned about RUST_LIB_BACKTRACE, and the surprising (to me) behavior that with RUST_BACKTRACE=1, you get Rust traces dumped to stderr even for errors that are generated and cleanly handled (like the error messages above). So I followed the guidance in the
So I've set RUST_BACKTRACE=1 and RUST_LIB_BACKTRACE=0. |
It was pointed out in oxide-rust that the reason I was getting the backtraces for handled errors wasn't that they were being printed synchronously when the error was created. Rather, they were being captured in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. Thanks for doing this!
This is basically to help debug issues like #6505.