Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native TCP ports to test ClickHouseDeployments #6603

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Add native TCP ports to test ClickHouseDeployments #6603

merged 5 commits into from
Sep 19, 2024

Conversation

bnaecker
Copy link
Collaborator

This lets ClickHouse use a random OS port for its native TCP protocol. Fixes #6592.

@bnaecker
Add native TCP ports to test ClickHouseDeployments
c994aed 
This lets ClickHouse use a random OS port for its native TCP protocol.
Fixes #6592.
@bnaecker bnaecker mentioned this pull request Sep 19, 2024
Merged
karencfv
karencfv reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@karencfv karencfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a few optional nits, and I think there's a bit of code that needs finishing up :)

@bnaecker bnaecker requested a review from karencfv September 19, 2024 06:12
@karencfv
Copy link
Contributor

Looks like your failed test is a known flake. There is an open PR to help catch what's happening.

karencfv
karencfv approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@karencfv karencfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments!

jgallagher
jgallagher approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits/questions.

@bnaecker bnaecker enabled auto-merge (squash) September 19, 2024 16:55
@bnaecker bnaecker mentioned this pull request Sep 19, 2024
Closed
@bnaecker
Copy link
Collaborator Author

Ran into a test flake, tracked in #6613. Re-running the job now.

@bnaecker bnaecker merged commit fb5d793 into main Sep 19, 2024
17 checks passed
@bnaecker bnaecker deleted the add-clickhouse-native-ports branch September 19, 2024 23:32
@davepacheco davepacheco mentioned this pull request Feb 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgallagher jgallagher jgallagher approved these changes

@karencfv karencfv karencfv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClickHouse instances in tests need to use an OS-assigned TCP port
3 participants
@bnaecker @karencfv @jgallagher