Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete crutest perf test #1528

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Remove obsolete crutest perf test #1528

merged 2 commits into from
Nov 1, 2024

Conversation

leftwo
Copy link
Contributor

@leftwo leftwo commented Nov 1, 2024

Remove the perf test from crutest. There are other better tests now and this one is just a distraction.

Removed the tools/test_perf.sh script and places that referenced it.

Fix for: #1527

Remove the perf test from crutest.  There are other better tests now and
this one is just a distraction.

Removed the tools/test_perf.sh script and places that referenced it.
@leftwo leftwo requested a review from mkeeter November 1, 2024 00:03
Copy link
Contributor

@mkeeter mkeeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, -738 → automatic approval from me

(although CI seems mad about it)

@leftwo
Copy link
Contributor Author

leftwo commented Nov 1, 2024

+1, -738 → automatic approval from me

Ignore my coming 800 line all comment PR that I'll use later for automatc approval.

(although CI seems mad about it)

There was a reference to tools/test_perf.sh in the buildomat post release build steps that I missed.

@leftwo leftwo merged commit 06ca533 into main Nov 1, 2024
16 checks passed
@leftwo leftwo deleted the alan/no-more-perf-test branch November 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants