Remove obsolete crutest perf test (#1528)

Remove the perf test from crutest. There are other better tests now and
this one is just a distraction.

Removed the tools/test_perf.sh script and places that referenced it.

Fix for: #1527

---------

Co-authored-by: Alan Hanson <alan@oxide.computer>

Author: leftwo

.github/buildomat/jobs/build-release.sh

@@ -81,7 +81,7 @@ for t in crucible-downstairs crucible-hammer crutest dsc crudd; do
 done
 
 mkdir -p /work/scripts
-for s in tools/test_perf.sh tools/crudd-speed-battery.sh tools/dtrace/perf-downstairs-tick.d tools/dtrace/upstairs_info.d tools/test_mem.sh; do
+for s in tools/crudd-speed-battery.sh tools/dtrace/perf-downstairs-tick.d tools/dtrace/upstairs_info.d tools/test_mem.sh; do
 	cp "$s" /work/scripts/
 done
 

Cargo.lock

@@ -15,7 +15,6 @@ crucible-client-types.workspace = true
 crucible-common.workspace = true
 crucible-protocol.workspace = true
 crucible.workspace = true
-csv.workspace = true
 dsc-client.workspace = true
 human_bytes.workspace = true
 futures-core.workspace = true

crutest/Cargo.toml

@@ -145,24 +145,6 @@ enum CliCommand {
     Info,
     /// Report if the Upstairs is ready for IO
     IsActive,
-    /// Run the client perf test
-    Perf {
-        /// Number of IOs to execute for each test phase
-        #[clap(long, short, default_value = "5000", action)]
-        count: usize,
-        /// Size in blocks of each IO
-        #[clap(long, default_value = "1", action)]
-        io_size: usize,
-        /// Number of outstanding IOs at the same time
-        #[clap(long, default_value = "1", action)]
-        io_depth: usize,
-        /// Number of read test loops to do.
-        #[clap(long, default_value = "2", action)]
-        read_loops: usize,
-        /// Number of write test loops to do.
-        #[clap(long, default_value = "2", action)]
-        write_loops: usize,
-    },
     /// Quit the CLI
     Quit,
     /// Read from a given block offset
@@ -522,22 +504,6 @@ async fn cmd_to_msg(
         CliCommand::Info => {
             fw.send(CliMessage::InfoPlease).await?;
         }
-        CliCommand::Perf {
-            count,
-            io_size,
-            io_depth,
-            read_loops,
-            write_loops,
-        } => {
-            fw.send(CliMessage::Perf(
-                count,
-                io_size,
-                io_depth,
-                read_loops,
-                write_loops,
-            ))
-            .await?;
-        }
         CliCommand::Quit => {
             println!("The quit command has nothing to send");
             return Ok(());
@@ -936,35 +902,6 @@ async fn process_cli_command(
                 Err(e) => fw.send(CliMessage::Error(e)).await,
             }
         }
-        CliMessage::Perf(count, io_size, io_depth, read_loops, write_loops) => {
-            if let Some(ri) = ri_option {
-                perf_header();
-                match perf_workload(
-                    volume,
-                    ri,
-                    None,
-                    count,
-                    io_size,
-                    io_depth,
-                    read_loops,
-                    write_loops,
-                )
-                .await
-                {
-                    Ok(_) => fw.send(CliMessage::DoneOk).await,
-                    Err(e) => {
-                        let msg = format!("{}", e);
-                        let e = CrucibleError::GenericError(msg);
-                        fw.send(CliMessage::Error(e)).await
-                    }
-                }
-            } else {
-                fw.send(CliMessage::Error(CrucibleError::GenericError(
-                    "Info not initialized".to_string(),
-                )))
-                .await
-            }
-        }
         CliMessage::RandRead => {
             if let Some(ri) = ri_option {
                 let mut rng = rand_chacha::ChaCha8Rng::from_entropy();